Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of GlusterFS code from the repo #112015

Merged
merged 2 commits into from Sep 14, 2022
Merged

Removal of GlusterFS code from the repo #112015

merged 2 commits into from Sep 14, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 24, 2022 •
edited

This PR removes GlusterFS in-tree driver code from the repository. This driver was marked for deprecation in 1.25.

Reference

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind cleanup

Additional Ref#
Issue #100897

GlusterFS in-tree storage driver which was deprecated at kubernetes 1.25 release has been removed entirely in 1.26.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 24, 2022
@humblec humblec changed the title Removal of GlusterFS code from the repo [WIP]Removal of GlusterFS code from the repo Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Aug 25, 2022
@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 25, 2022
@dims
Copy link
Member

dims commented Aug 26, 2022

@humblec looks like the CI is not yet green

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 13, 2022
@liggitt
Copy link
Member

liggitt commented Sep 14, 2022

/approve
for deps changes

removal of hold is up to sig-storage leads

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, liggitt, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@dims
Copy link
Member

dims commented Sep 14, 2022

ack @liggitt we can wait for a day or so and then remove hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 14, 2022
@xing-yang
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@xing-yang
Copy link
Contributor

@humblec Can you check why it says release notes not added?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 14, 2022
@dims
Copy link
Member

dims commented Sep 14, 2022

@xing-yang it says the label was removed, needs a refresh of the page?. Here's what i see on the labels section on top.

image

@humblec
Copy link
Contributor Author

humblec commented Sep 14, 2022

@humblec Can you check why it says release notes not added?

Looks like an interim state for some reason but we are good atm @xing-yang

@k8s-ci-robot k8s-ci-robot merged commit ee94dce into kubernetes:master Sep 14, 2022
SIG Node CI/Test Board automation moved this from Triage to Done Sep 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 14, 2022
@dims
Copy link
Member

dims commented Sep 14, 2022

/meow

@k8s-ci-robot
Copy link
Contributor

@dims: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec
Copy link
Contributor Author

humblec commented Sep 15, 2022

Those sleepless nights to get this in for v1.4.. 😿

humblec added a commit to humblec/kubernetes that referenced this pull request Sep 27, 2022
@humblec
remove glusterfs dynamic provisioner server
9d148a4 
Considering we have removed the glusterfs driver from the
repo, we no longer need the test server for CI. This commit
remove the same

Ref# kubernetes#112015

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec mentioned this pull request Sep 27, 2022
Merged
@Kartik494 Kartik494 mentioned this pull request Nov 14, 2022
Closed
@xing-yang xing-yang mentioned this pull request Jan 12, 2023
Merged
This was referenced Apr 28, 2023
Merged
Open
@brandond brandond mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@liggitt liggitt

@xing-yang xing-yang

@jsafrane jsafrane

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@humblec @leilajal @dims @k8s-ci-robot @liggitt @xing-yang @saad-ali @jsafrane @msau42