Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 114857 to release-1.26 #114861

Merged
merged 1 commit into from Jan 12, 2023
Merged

Cherry pick 114857 to release-1.26 #114861

merged 1 commit into from Jan 12, 2023

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Jan 5, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes #114661 by picking up google/cel-go#620

This bug can cause all requests matching the admission rules fail with an error rather than be properly validated.

Which issue(s) this PR fixes:

Fixes #114661

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix bug in CRD Validation Rules (beta) and ValidatingAdmissionPolicy (alpha) where all admission requests could result in `internal error: runtime error: index out of range [3] with length 3 evaluating rule: <rule name>` under certain circumstances.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Jan 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from derekwaynecarr and a team January 5, 2023 20:43
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2023
@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 5, 2023

/sig api-machinery
/triage accepted
cc @liggitt @TristonianJones

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 5, 2023
@liggitt
Copy link
Member

liggitt commented Jan 5, 2023

/lgtm
/approve
/priority important-soon
/kind bug
/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team January 5, 2023 21:50
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 70a4b693fc9a25e72245e926e71667f4201aec69

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2023
@xmudrii
Copy link
Member

xmudrii commented Jan 6, 2023

@jpbetz @liggitt Just to make sure, we don't need to cherry-pick this to 1.23?

@liggitt
Copy link
Member

liggitt commented Jan 6, 2023

@jpbetz @liggitt Just to make sure, we don't need to cherry-pick this to 1.23?

CEL was promoted to beta in 1.25, so 1.24 is the earliest server version that could be exposed to this issue without having opted into an alpha feature... I don't think we should take this back to 1.23

@Verolop
Copy link

Verolop commented Jan 12, 2023

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit e2093f8 into kubernetes:release-1.26 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpbetz @liggitt @k8s-ci-robot @xmudrii @Verolop