Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NeedResize build failure on Windows #109721

Merged
merged 1 commit into from May 3, 2022
Merged

fix: NeedResize build failure on Windows #109721

merged 1 commit into from May 3, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

When use mount-utils NeedResize func, if current driver supports Windows build, we would hit following error, this PR fixes the build issue on Windows

# make azuredisk-windows
CGO_ENABLED=0 GOOS=windows go build -a -ldflags "-X sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.driverVersion=v1.17.0 -X sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.gitCommit=cd4b22d8db0bf657092fec966c881c91f8f10cd3 -X sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.buildDate=2022-04-29T08:12:12Z -extldflags "-static""  -mod vendor -o _output/amd64/azurediskplugin.exe ./pkg/azurediskplugin
# sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk
pkg/azuredisk/nodeserver.go:175:32: resizer.NeedResize undefined (type *mount.ResizeFs has no field or method NeedResize)
Makefile:154: recipe for target 'azuredisk-windows' failed

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: NeedResize build failure on Windows

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: NeedResize build failure on Windows

/kind bug
/assign @msau42
/priority important-soon
/sig storage
/triage accepted

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 29, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Apr 29, 2022
@andyzhangx
Copy link
Member Author

/assign @jsafrane

@andyzhangx andyzhangx mentioned this pull request Apr 29, 2022
Closed
4 tasks
@andyzhangx
Copy link
Member Author

/retest

@jsafrane
Copy link
Member

jsafrane commented May 3, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2022
@jsafrane
Copy link
Member

jsafrane commented May 3, 2022

/milestone 1.24
This is small and well localized that it can't break anything.
(not sure why the milestone is needed when there already is a separate release-1.24 branch)

@k8s-ci-robot
Copy link
Contributor

@jsafrane: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.24
This is small and well localized that it can't break anything.
(not sure why the milestone is needed when there already is a separate release-1.24 branch)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Member

jsafrane commented May 3, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone May 3, 2022
@jsafrane
Copy link
Member

jsafrane commented May 3, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 70d470e into kubernetes:master May 3, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.24, v1.25 May 3, 2022
@github-actions github-actions bot mentioned this pull request May 11, 2022
Open
@RomanBednar RomanBednar mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyzhangx @k8s-ci-robot @jsafrane @msau42