New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: kubelet: cpumgr: CPU Manager to GA #113018
node: kubelet: cpumgr: CPU Manager to GA #113018
Conversation
@fromanirh: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/sig node |
For the release note, Markdown is supported. Consider hyperlinking to https://kubernetes.io/docs/tasks/administer-cluster/cpu-management-policies/ or to a similar docs page. |
/triage-accepted Link to the enhancement in the PR description needs to be updated to kubernetes/enhancements#3570. |
@swatisehgal: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
/lgtm /assign @derekwaynecarr @dchen1107 @dims |
Looks like all the paperwork is good for 1.26. /approve |
/hold |
/hold cancel |
/retest |
/lgtm |
/cc @derekwaynecarr @dchen1107 |
/assign @derekwaynecarr |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, fromanirh, klueska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Francesco Romani <fromani@redhat.com>
hence we can remove the if() guards, the feature is always available. Signed-off-by: Francesco Romani <fromani@redhat.com>
Add docstrings and trivial fixes. Signed-off-by: Francesco Romani <fromani@redhat.com>
CPUManager is going GA, thus it makes little sense to keep the names of the internal configuration variables `Experimental*`. Trivial rename only. Signed-off-by: Francesco Romani <fromani@redhat.com>
24efa39
to
a6b928d
Compare
/lgtm |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Changes to finalize the graduation of CPUManager to GA
Which issue(s) this PR fixes:
Enhancement: kubernetes/enhancements#3570
Special notes for your reviewer:
As per the enhancement review, especially PRR, we need to fill gaps before to merge this PR, which is the final step to graduate to GA.
Dependencies:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: