Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: kubelet: cpumgr: CPU Manager to GA #113018

Merged
merged 4 commits into from Nov 2, 2022
Merged

node: kubelet: cpumgr: CPU Manager to GA #113018

merged 4 commits into from Nov 2, 2022

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Oct 12, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Changes to finalize the graduation of CPUManager to GA

Which issue(s) this PR fixes:

Enhancement: kubernetes/enhancements#3570

Special notes for your reviewer:

As per the enhancement review, especially PRR, we need to fill gaps before to merge this PR, which is the final step to graduate to GA.
Dependencies:

Does this PR introduce a user-facing change?

Graduate Kubelet CPU Manager to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/pull/3570

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

@fromanirh: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2022
@ffromani ffromani mentioned this pull request Oct 12, 2022
Closed
4 tasks
@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2022
@sftim sftim mentioned this pull request Oct 13, 2022
Closed
@sftim
Copy link
Contributor

sftim commented Oct 13, 2022

For the release note, Markdown is supported. Consider hyperlinking to https://kubernetes.io/docs/tasks/administer-cluster/cpu-management-policies/ or to a similar docs page.

@swatisehgal
Copy link
Contributor

swatisehgal commented Oct 13, 2022 •
edited

/triage-accepted
/priority important-soon
(as CPU Manager graduation to GA is planned for 1.26 release)

Link to the enhancement in the PR description needs to be updated to kubernetes/enhancements#3570.

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 13, 2022
@k8s-ci-robot
Copy link
Contributor

@swatisehgal: The label(s) priority/(as, priority/cpu, priority/manager, priority/graduation, priority/to, priority/ga, priority/is, priority/planned, priority/for, priority/1.26, priority/release) cannot be applied, because the repository doesn't have them.

In response to this:

/triage-accepted
/priority important-soon (as CPU Manager graduation to GA is planned for 1.26 release)

Link to the enhancement needs to be updated to kubernetes/enhancements#3570.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 13, 2022
@swatisehgal
Copy link
Contributor

/priority important-soon

@swatisehgal
Copy link
Contributor

/lgtm
from node perspective (non-binding)

/assign @derekwaynecarr @dchen1107 @dims
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2022
@dims
Copy link
Member

dims commented Oct 20, 2022

Looks like all the paperwork is good for 1.26.

/approve

@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/hold
comment about e2e test still to be answered

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/hold cancel
comment addressed

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/retest

@klueska
Copy link
Contributor

klueska commented Nov 2, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@klueska
Copy link
Contributor

klueska commented Nov 2, 2022

/cc @derekwaynecarr @dchen1107
For final features approval

@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/assign @derekwaynecarr
as feature approver for node (per OWNER_ALIASES)

@dims
Copy link
Member

dims commented Nov 2, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, fromanirh, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/retest
the failure seems unrelated

@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/retest
image

@ffromani
node: kubelet: cpumgr: CPU Manager to GA
c8ab5a0 
Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
cpumanager: the FG is locked to default (ON)
ff44dc1 
hence we can remove the if() guards, the feature
is always available.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
node: cpumgr: address golint complains
5e12338 
Add docstrings and trivial fixes.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
kubelet: cpumgr: internal variable trivial rename
a6b928d 
CPUManager is going GA, thus it makes little sense
to keep the names of the internal configuration
variables `Experimental*`.

Trivial rename only.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022 •
edited

rebased to fix conflicts
image

@swatisehgal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Nov 2, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 433787d into kubernetes:master Nov 2, 2022
SIG Node PR Triage automation moved this from Waiting on Author to Done Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 2, 2022
@ffromani ffromani deleted the cpumanager-ga-features branch November 3, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dims dims

@klueska klueska

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ffromani @k8s-ci-robot @sftim @swatisehgal @dims @klueska @derekwaynecarr @dchen1107