fix double lock and excercise its codepath in tests #114459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
|
/retest |
|
looks like github is making prow unhappy:
/retest |
|
/lgtm go ahead and open the cherry-pick to release-1.26 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
would cause a deadlock if an aggregated apiserver decided to respect ETags for its aggregated discovery document,
alexzielenski
force-pushed
the
apiserver/discovery/aggregator-deadlock
branch
from
09fdda6
to
7510afb
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 14, 2022
…f-#114459-upstream-release-1.26 Automated cherry pick of #114459: fix double lock and excercise its codepath in tests
liggitt
added
the
kind/regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
This removes a duplicate lock on the 304 Not Modified codepath likely forgotten to be removed during a refactor.
It is probable that no users have discovered this bug, as it occurs only if the user has an aggregated APIService which makes use of aggregated discovery, which was just released a few days ago.
Also includes a reproducer unit test which fails easily without the change, and is now fixed.
More information in #114442
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: