Make the validation logic about LeaderElectionConfiguration consistent between component-base and client-go #111758
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
As the description
LeaseDuration must be greater than RenewDeadline
, we should usecc.LeaseDuration.Duration <= cc.RenewDeadline.Duration
rather thancc.LeaseDuration.Duration < cc.RenewDeadline.Duration
.kubernetes/staging/src/k8s.io/component-base/config/validation/validation.go
Lines 48 to 50 in a837be0
We already use
<=
in client-go similar code:kubernetes/staging/src/k8s.io/client-go/tools/leaderelection/leaderelection.go
Lines 78 to 80 in a837be0
And the validation logic should be consistent between
component-base
andclient-go
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: