New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the validation logic about LeaderElectionConfiguration consistent between component-base and client-go #111758
Make the validation logic about LeaderElectionConfiguration consistent between component-base and client-go #111758
Conversation
…t between component-base and client-go
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/retest |
/assign @jiahuif |
Good point. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
As the description
LeaseDuration must be greater than RenewDeadline
, we should usecc.LeaseDuration.Duration <= cc.RenewDeadline.Duration
rather thancc.LeaseDuration.Duration < cc.RenewDeadline.Duration
.kubernetes/staging/src/k8s.io/component-base/config/validation/validation.go
Lines 48 to 50 in a837be0
We already use
<=
in client-go similar code:kubernetes/staging/src/k8s.io/client-go/tools/leaderelection/leaderelection.go
Lines 78 to 80 in a837be0
And the validation logic should be consistent between
component-base
andclient-go
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: