Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove in-tree openstack cloud provider #67782

Merged
merged 2 commits into from Aug 24, 2022
Merged

Remove in-tree openstack cloud provider #67782

merged 2 commits into from Aug 24, 2022

Conversation

dims
Copy link
Member

@dims dims commented Aug 23, 2018 •
edited

What this PR does / why we need it:

As part of the KEP process for Removing Cloud Providers from Kubernetes Core, We have moved the code over to https://github.com/kubernetes/cloud-provider-openstack.

Please see the issue:
kubernetes/enhancements#1489

and the following KEPs for additional information:

There are still API data structures related to cinder volumes that will still remain here in the main k/k repository. The main thing being removed is the in-tree cloud provider and the in-tree support for cinder volumes. Please use the documentation and code from https://github.com/kubernetes/cloud-provider-openstack.

The in-tree cloud provider was deprecated in #63524

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
/milestone v1.13

Release note:

The in-tree cloud provider for OpenStack (and the cinder volume provider) has now been removed. Please use the external cloud provider and csi driver from https://github.com/kubernetes/cloud-provider-openstack instead.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 23, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Aug 23, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 23, 2018
@gnufied
Copy link
Member

gnufied commented Aug 24, 2018

Is Cinder CSI driver has all necessary pieces to do this? Will this stop in-tree Cinder volumes from working?

@gnufied
Copy link
Member

gnufied commented Aug 24, 2018

okay, I see this is for 1.13.. I will stop panicking now. :D

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2018
@wenjiaswe
Copy link
Contributor

cc @cheftako

@dims dims mentioned this pull request Sep 4, 2018
Merged
@dims
Copy link
Member Author

dims commented Sep 24, 2018

will revisit this later.

@dims dims closed this Sep 24, 2018
@dims dims reopened this Sep 27, 2018
@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Sep 27, 2018
@dims dims force-pushed the yank-in-tree-openstack-cloud-provider branch from 7ded937 to 4c33c7b Compare September 27, 2018 20:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2018
@dims dims force-pushed the yank-in-tree-openstack-cloud-provider branch 3 times, most recently from 040635c to 348b077 Compare September 27, 2018 21:33
@dims
Copy link
Member Author

dims commented Sep 27, 2018

/test pull-kubernetes-node-e2e
/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 22, 2022
@dims
Copy link
Member Author

dims commented Aug 22, 2022

/assign @thockin

@k8s-ci-robot
Copy link
Contributor

@dims: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-local-e2e-containerized cdaa3c3aac0c9713954d6bbfb0976e4c5fb57c51 link /test pull-kubernetes-local-e2e-containerized
pull-kubernetes-e2e-gce-alpha-features 9bbf01b link false /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-local-e2e 9bbf01b link false /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member Author

dims commented Aug 23, 2022

/skip

@thockin
Copy link
Member

thockin commented Aug 23, 2022

This is terrifying. This ia massively breaking change, and I have not followed this process as closely as I would have liked, so I feel obligated to ask:

  • Where/when have we talked about this and announced it previously?
  • Where have we published a migration HOWTO doc?

Can we update the PR comment to reflect this?

@dims
Copy link
Member Author

dims commented Aug 24, 2022 •
edited

@thockin LOL, there's like a half a dozen keps :) updated the PR comment. the final nail was kubernetes/enhancements#3462 migration notes were added in https://github.com/kubernetes/website/pull/32495/files

@dims
Copy link
Member Author

dims commented Aug 24, 2022 •
edited

@xing-yang @msau42 @jsafrane if you want to add more context.

@thockin
Copy link
Member

thockin commented Aug 24, 2022

Mostly I just want to make sure that we set a precedent that this sort of nuclear bomb PR is self-contained enough for a poor user to find all the relevant info how to un-kill their cluster :)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 07bca2d into kubernetes:master Aug 24, 2022
@dims
Copy link
Member Author

dims commented Aug 26, 2022

Also see blog that is being drafted for more context: kubernetes/website#36183

This was referenced Nov 10, 2022
Closed
Merged
@mandre mandre mentioned this pull request Dec 19, 2022
Merged
@xmudrii xmudrii mentioned this pull request Jan 1, 2023
Merged
ialidzhikov added a commit to gardener/gardener-extension-provider-openstack that referenced this pull request Jan 11, 2023
@ialidzhikov
Adapt to the removal of the CSIMigrationOpenStack and `InTreePlugin…
0d97fe8 
…OpenStackUnregister` feature gates

These feature gates are removed with kubernetes/kubernetes#67782
ialidzhikov added a commit to gardener/gardener-extension-provider-openstack that referenced this pull request Jan 30, 2023
@ialidzhikov
Adapt to the removal of the CSIMigrationOpenStack and `InTreePlugin…
6e7c8b9 
…OpenStackUnregister` feature gates

These feature gates are removed with kubernetes/kubernetes#67782
ialidzhikov added a commit to ialidzhikov/gardener-extension-provider-openstack that referenced this pull request Feb 3, 2023
@ialidzhikov
Adapt to the removal of the CSIMigrationOpenStack and `InTreePlugin…
e063b73 
…OpenStackUnregister` feature gates

These feature gates are removed with kubernetes/kubernetes#67782
kon-angelo pushed a commit to gardener/gardener-extension-provider-openstack that referenced this pull request Feb 10, 2023
@ialidzhikov
Support for Kubernetes v1.26 (#551)
95cb804 
* Add Kubernetes 1.26 support to README.md

* Update cloud-controller-manager images

* Adapt to the removal of the `CSIMigrationOpenStack` and `InTreePluginOpenStackUnregister` feature gates

These feature gates are removed with kubernetes/kubernetes#67782
@dims dims mentioned this pull request Feb 17, 2023
Merged
@mumoshu mumoshu mentioned this pull request Apr 24, 2023
Merged
@thaJeztah thaJeztah mentioned this pull request May 22, 2023
Merged
@mengjiao-liu mengjiao-liu mentioned this pull request Jul 31, 2023
Merged
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/kubelet area/provider/gcp Issues or PRs related to gcp provider area/provider/openstack Issues or PRs related to openstack provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet