New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve winkernel proxier treating stale VIPs as valid #113521
resolve winkernel proxier treating stale VIPs as valid #113521
Conversation
@daschott: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig windows |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daschott, sbangari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…3521-upstream-release-1.24 Automated cherry pick of #113521: added backend hashing to winkernel proxier
…3521-upstream-release-1.25 Automated cherry pick of #113521: added backend hashing to winkernel proxier
What type of PR is this?
/kind bug
What this PR does / why we need it:
There is an issue on Windows Server 2019 that can cause the kube-proxy call into HNS to delete the load balancer proxy rules to fail. This case is not handled very well and we should add resiliency for such failures. If the backends of a particular services are all deleted, but the call to HNS to cleanup the load balancer proxy rules did not succeed, if the same service get's re-created again in the future and the number of new endpoints matches the number of endpoints that used to exist, kube-proxy will think that the old service policy proxy rules that never got deleted is still valid. This will lead to in-cluster network failures for traffic passing through Windows Nodes.
To improve on this issue this PR:
Which issue(s) this PR fixes:
Fixes #113524
Special notes for your reviewer:
At this time, I have not confirmed if this issue also occurs on Windows Server 2022.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: