New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: devicemgr: Graduate Kubelet DeviceManager to GA #112980
node: devicemgr: Graduate Kubelet DeviceManager to GA #112980
Conversation
87503b2
to
af9469a
Compare
/test pull-kubernetes-unit |
/sig node |
/priority important-soon |
/triage accepted |
/uncc |
/cc @fromanirh @klueska |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (soft, non-binding) because: this change is correct; I'm not sure the rest of the code (and the tests) should be changed to consider the feature always on. Should this be changed when we lock the feature gate, or should we do this when we remove the feature gate? Or are both acceptable?
Good point, I will look for references to the |
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
also @endocrimes for |
/test pull-kubernetes-e2e-capz-windows-containerd |
/retest |
/restest |
@swatisehgal could it be that alpha-features test fails because device manager tries to call device plugin, but no plugin is available? |
I won't say I am 100% sure but it doesn't look like that is the case here. On inspection of the test args of pull-kubernetes-e2e-gce-alpha-features job here device manager e2e tests are not being executed as part of the job. Also the build logs show that the failures have nothing to do with device manager. Both the jobs (pull-kubernetes-e2e-gce-alpha-features and pull-kubernetes-e2e-capz-windows-containerd ) appear to be very flaky on testgrid. Also, both are not showing up as /retest |
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
With graduation of device plugins to GA in 1.26, the feature gate is enabled by default so `devicePluginEnabled` field no longer needs to be passed at the time of Container Manager creation. In addition to that, we remove the `ManagerStub` as it is no longer needed. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
9971ce6
to
4074168
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, klueska, swatisehgal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-integration |
/test pull-kubernetes-e2e-kind |
/retest |
1 similar comment
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Captures changes to graduate Kubelet Device Manager to GA.
Which issue(s) this PR fixes:
Issue: kubernetes/enhancements#3573
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: