Added: publishing events for topologyAwareHints changes #113544

LiorLieberman · 2022-11-02T12:22:16Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

See PR title

Does this PR introduce a user-facing change?

Added: publishing events when enabling/disabling topologyAwareHints.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Enhancement Issue: kubernetes/enhancements#2433

linux-foundation-easycla · 2022-11-02T12:22:21Z

The committers listed above are authorized under a signed CLA.

✅ login: LiorLieberman / name: Lior Lieberman (16722655d95a64f4cf56840a7f9d0cedce708861, 02540031e30524f484ae69d2f285426b542e6532, a62937dab38d35c8aa8448b3a55c1a3e27800b76, ece7c451af603b6898fe2cc649730ef77c2dee2e)

k8s-ci-robot · 2022-11-02T12:22:24Z

Welcome @LiorLieberman!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-11-02T12:22:25Z

Hi @LiorLieberman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

robscott

Thanks @LiorLieberman! These changes mostly LGTM, just a few nits. A few overall requests on the PR as well:

Please squash the commits down to a single one (or small set if that provides a clearer story).
Please fill out the relevant fields in the PR description, especially the release note section.
Please link to Topology Aware Routing enhancements#2433 as the enhancement issue
Remove WIP from the title whenever you think this is ready

pkg/controller/endpointslice/topologycache/event.go

pkg/controller/endpointslice/topologycache/topologycache.go

robscott · 2022-11-05T00:19:43Z

/cc @swetharepakula @aojea

pkg/controller/endpointslice/topologycache/event.go

pkg/controller/endpointslice/reconciler.go

pkg/controller/endpointslice/topologycache/topologycache.go

aojea · 2022-11-07T18:09:55Z

pkg/controller/endpointslice/topologycache/topologycache.go

+	if t.cpuRatiosByZone == nil {
+		return nil, &EventBuilder{
+			EventType: v1.EventTypeWarning,
+			Reason:    "TopologyAwareHintsDisabled",
+			Message:   InsufficientNodeInfo,
+		}
+	}
+	if len(t.cpuRatiosByZone) < 2 {
+		return nil, &EventBuilder{
+			EventType: v1.EventTypeWarning,
+			Reason:    "TopologyAwareHintsDisabled",
+			Message:   NodesReadyInOneZoneOnly,
+		}
+	}
+	if len(t.cpuRatiosByZone) > numEndpoints {
+		return nil, &EventBuilder{
+			EventType: v1.EventTypeWarning,
+			Reason:    "TopologyAwareHintsDisabled",
+			Message:   fmt.Sprintf("%s (%d endpoints, %d zones)", InsufficientNumberOfEndpoints, numEndpoints, len(t.cpuRatiosByZone)),
+		}
 	}


what if we aggregate here, if we return fast we miss the other checks, that are another reason for not having hints too.

My point is if I'm using this and I hit this 3 problems, I will have to fix 1 by 1, if I see the 3 errors I may fix all of them

+1, having information about all 3 would be very useful.

You suggest to publish all 3 events right? not one that contains all of them

your call, I don't have strong opinion, Swetha or Rob may have some ideas

@aojea @swetharepakula thinking further, it is not a good place to aggregate as all these events are mutually exclusive. you could see we check t.cpuRatiosByZone in all of them.
Moreover, if its nil, we will get exception checking for its length in the next condition.

You're right. I think how it is makes sense. Thanks!

pkg/controller/endpointslice/topologycache/topologycache.go

robscott · 2022-11-07T19:51:51Z

Thanks @LiorLieberman!

/lgtm
/approve

k8s-ci-robot · 2022-11-07T19:52:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/controller/endpointslice/OWNERS~~ [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LiorLieberman · 2022-11-07T20:35:58Z

/retest

swetharepakula · 2022-11-07T21:26:41Z

LGTM. Thanks @LiorLieberman !

k8s-ci-robot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 2, 2022

k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 2, 2022

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 2, 2022

LiorLieberman changed the title ~~WIP publishing events from the EndpointSlice controller for changes i…~~ WIP publishing events for changes in the topologyHints feature Nov 2, 2022

k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 2, 2022

k8s-ci-robot requested review from caseydavenport and khenidak November 2, 2022 12:26

LiorLieberman closed this Nov 2, 2022

LiorLieberman reopened this Nov 3, 2022

LiorLieberman changed the title ~~WIP publishing events for changes in the topologyHints feature~~ publishing events for changes in the topologyAwareHints Nov 3, 2022

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022

robscott reviewed Nov 5, 2022

View reviewed changes

pkg/controller/endpointslice/topologycache/topologycache.go Outdated Show resolved Hide resolved

k8s-ci-robot requested review from aojea and swetharepakula November 5, 2022 00:19

LiorLieberman force-pushed the topology-hints-events branch from be75404 to 7562e87 Compare November 5, 2022 15:42

LiorLieberman changed the title ~~WIP publishing events for changes in the topologyAwareHints~~ Added events publishing for topologyAwareHints changes Nov 5, 2022

LiorLieberman changed the title ~~Added events publishing for topologyAwareHints changes~~ Added: publishing events for topologyAwareHints changes Nov 5, 2022

aojea reviewed Nov 7, 2022

View reviewed changes

pkg/controller/endpointslice/topologycache/event.go Outdated Show resolved Hide resolved

aojea reviewed Nov 7, 2022

View reviewed changes

pkg/controller/endpointslice/reconciler.go Show resolved Hide resolved

aojea reviewed Nov 7, 2022

View reviewed changes

pkg/controller/endpointslice/topologycache/topologycache.go Show resolved Hide resolved

aojea reviewed Nov 7, 2022

View reviewed changes

pkg/controller/endpointslice/topologycache/topologycache.go Show resolved Hide resolved

Added events publishing for topologyHints changes

4faede0

LiorLieberman force-pushed the topology-hints-events branch from 48c4ac5 to 4faede0 Compare November 7, 2022 19:46

k8s-ci-robot assigned robscott Nov 7, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022

k8s-ci-robot merged commit 0e530f4 into kubernetes:master Nov 8, 2022

k8s-ci-robot added this to the v1.26 milestone Nov 8, 2022

robscott mentioned this pull request Nov 9, 2022

Topology Aware Routing kubernetes/enhancements#2433

Open

4 tasks

robscott mentioned this pull request Jan 6, 2023

Fix nil addresstype #113638

Closed

LiorLieberman mentioned this pull request Jan 9, 2023

REQUEST: New membership for LiorLieberman kubernetes/org#3924

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added: publishing events for topologyAwareHints changes #113544

Added: publishing events for topologyAwareHints changes #113544

LiorLieberman commented Nov 2, 2022 •

edited

linux-foundation-easycla bot commented Nov 2, 2022 •

edited

k8s-ci-robot commented Nov 2, 2022

k8s-ci-robot commented Nov 2, 2022

robscott left a comment •

edited

robscott commented Nov 5, 2022

aojea Nov 7, 2022 •

edited

swetharepakula Nov 7, 2022

LiorLieberman Nov 7, 2022

aojea Nov 7, 2022

LiorLieberman Nov 7, 2022

swetharepakula Nov 7, 2022

robscott commented Nov 7, 2022

k8s-ci-robot commented Nov 7, 2022

LiorLieberman commented Nov 7, 2022

swetharepakula commented Nov 7, 2022

Added: publishing events for topologyAwareHints changes #113544

Added: publishing events for topologyAwareHints changes #113544

Conversation

LiorLieberman commented Nov 2, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

linux-foundation-easycla bot commented Nov 2, 2022 • edited

k8s-ci-robot commented Nov 2, 2022

k8s-ci-robot commented Nov 2, 2022

robscott left a comment • edited

Choose a reason for hiding this comment

robscott commented Nov 5, 2022

aojea Nov 7, 2022 • edited

Choose a reason for hiding this comment

swetharepakula Nov 7, 2022

Choose a reason for hiding this comment

LiorLieberman Nov 7, 2022

Choose a reason for hiding this comment

aojea Nov 7, 2022

Choose a reason for hiding this comment

LiorLieberman Nov 7, 2022

Choose a reason for hiding this comment

swetharepakula Nov 7, 2022

Choose a reason for hiding this comment

robscott commented Nov 7, 2022

k8s-ci-robot commented Nov 7, 2022

LiorLieberman commented Nov 7, 2022

swetharepakula commented Nov 7, 2022

LiorLieberman commented Nov 2, 2022 •

edited

linux-foundation-easycla bot commented Nov 2, 2022 •

edited

robscott left a comment •

edited

aojea Nov 7, 2022 •

edited