Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: bump runc to 1.1.3 #110496

Merged
merged 1 commit into from Jun 23, 2022
Merged

vendor: bump runc to 1.1.3 #110496

merged 1 commit into from Jun 23, 2022

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jun 9, 2022 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Release notes:
https://github.com/opencontainers/runc/releases/tag/v1.1.3

In particular, this one is important:

Which issue(s) this PR fixes:

I believe that this

Fixes: #100328

Special notes for your reviewer:

n/a

Does this PR introduce a user-facing change?

Fix "dbus: connection closed by user" error after dbus daemon restart.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

n/a

@kolyshkin
vendor: bump runc to 1.1.3
865c9e8 
Release notes:
 https://github.com/opencontainers/runc/releases/tag/v1.1.3

In particular, this one is important:

 * Retry on dbus disconnect logic in libcontainer/cgroups/systemd now
   works as intended; this fix does not affect runc binary itself but
   is important for libcontainer users such as Kubernetes. (kubernetes#3476)

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

@kolyshkin: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot requested review from logicalhan, wojtek-t and a team June 9, 2022 23:31
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 9, 2022
This was referenced Jun 9, 2022
Closed
Closed
@kolyshkin
Copy link
Contributor Author

/assign @dchen1107

@kolyshkin
Copy link
Contributor Author

/priority important-soon
/sig node
/cc @dims @bobbypage @liggitt

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 22, 2022
@bobbypage
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022
@dims
Copy link
Member

dims commented Jun 22, 2022

/approve
/lgtm

/assign @liggitt @thockin

(for root OWNER approval)

@liggitt
Copy link
Member

liggitt commented Jun 23, 2022

/approve

@liggitt
Copy link
Member

liggitt commented Jun 23, 2022

I believe that this

Fixes: #100328

is there a way to trigger / test that to be sure?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, kolyshkin, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 272386c into kubernetes:master Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 23, 2022
@kolyshkin
Copy link
Contributor Author

is there a way to trigger / test that to be sure?

Restart dbus (which can be triggered by upgrading or downgrading systemd and/or dbus I believe).

@kolyshkin kolyshkin mentioned this pull request Jun 23, 2022
Closed
kolyshkin added a commit to kolyshkin/kubernetes that referenced this pull request Jun 23, 2022
@kolyshkin
[1.24] vendor: bump runc to 1.1.3
ca1c58f 
This is a manual backport of PR kubernetes#110496 to release-1.24 branch.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@pandaamanda
Copy link
Contributor

pandaamanda commented Jul 12, 2022 •
edited

should be cherry-pick to kubernetes 1.22 and 1.23 release？

@endocrimes endocrimes mentioned this pull request Aug 8, 2022
Merged
@kolyshkin kolyshkin mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@bobbypage bobbypage Awaiting requested review from bobbypage

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@bobbypage bobbypage

@liggitt liggitt

@thockin thockin

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Kubernetes Pods create/Status unsure (kubelet) - dbus: connection closed by user
8 participants
@kolyshkin @k8s-ci-robot @bobbypage @dims @liggitt @pandaamanda @thockin @dchen1107