New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: Remove storageos volume plugins from k8s codebase #111620
Conversation
/triage accepted |
/milestone v1.25 |
As documented here, storageos plugin was deprecated in 1.22: |
/lgtm |
@Jiawei0227 good to have release note section filled. |
/retest |
I think I already did. Is there something else you are referring to? @humblec |
Oh.. |
This actually means this PR might be a breaking change so it need special attention. The release notes have already been filled in the description section |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Jiawei0227, liggitt, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
NOTE for release team: Last minute conflict in the rush before the code freeze, this had all the approvals, so we will try to rebase this correctly and merge it hopefully in a day. @Jiawei0227 can you please rebase? cc @xing-yang |
Done |
/retest |
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR removes storageos storage plugin from k8s codebase.
The storageos plugin has been deprecated since v1.22
https://groups.google.com/g/kubernetes-sig-storage/c/IDIVmifA1FA
The code removal removes the dependency of storageos api and reduce
maintenance burden from storage perspective.
The storageos API, per k8s api policy, will not be removed. Whenever user tries to create PV using the inline storageos API, the following event will show in the pod:
Warning FailedMount 7m35s (x55 over 22m) kubelet, kubernetes-minion-group-kq16 Unable to attach or mount volumes: unmounted volumes=[mypvc], unattached volumes=[mypvc kube-api-access-22hdk[]: failed to get Plugin from volumeSpec for volume "mypvc" err=no volume plugin matched
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig storage
/assign @msau42 @xing-yang @liggitt