Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote EndpointSliceTerminatingCondition to GA #113351

Merged
merged 5 commits into from Nov 4, 2022
Merged

Promote EndpointSliceTerminatingCondition to GA #113351

merged 5 commits into from Nov 4, 2022

Conversation

andrewsykim
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Per KEP update in kubernetes/enhancements#3504, this PR promote the EndpointSliceTerminatingCondition feature to GA. This feaure has been in Beta since v1.22 and meets GA graduation criterias:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The EndpointSliceTerminatingCondition feature gate has graduated to GA. The gate is now locked and will be removed in v1.28.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 26, 2022
@k8s-ci-robot k8s-ci-robot added area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 26, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 26, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@andrewsykim
Copy link
Member Author

/assign @robscott @thockin

robscott
robscott reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewsykim!

pkg/controller/endpointslice/reconciler.go Show resolved Hide resolved
pkg/controller/util/endpoint/controller_utils.go Show resolved Hide resolved
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 27, 2022
@aojea
Copy link
Member

aojea commented Nov 2, 2022

/lgtm
/assign  @thockin @robscott

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
thockin
thockin reviewed Nov 2, 2022
View reviewed changes
pkg/controller/endpointslice/reconciler_test.go
Addresses: []string{"1.2.3.4"},
Conditions: discovery.EndpointConditions{
Ready: utilpointer.BoolPtr(true),
Serving: utilpointer.BoolPtr(true),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these were not set before, does this change the nature of the tests (defaults to false) ? Do we need to modulate these fields for full test coverage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point -- let me check the existing test coverage and make sure we're adding cases for terminating endpoints in places we previously assumed it was disabled

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed tests coverage again -- I think by addiing the serving/terminating condition checks in all the tests that previously had the gate disabled and keeping the tests for terminating endpoints when the gate was enabled keeps our test coverage more or less the same as before.

I pushed a change to clean up some left over references to the feature gate in the test names though.

@thockin
Copy link
Member

thockin commented Nov 2, 2022

@robscott are you LGTM?

@robscott
Copy link
Member

robscott commented Nov 3, 2022

Thanks @andrewsykim!

/lgtm

@aojea
Copy link
Member

aojea commented Nov 3, 2022

@thockin needs approval

@thockin
Copy link
Member

thockin commented Nov 3, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@andrewsykim
Copy link
Member Author

/hold

I should follow-up on #113351 (comment) before merging, make sure we're happy with the test coverage.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@andrewsykim
promote EndpointSliceTerminatingCondition feature gate to GA
c11368c 
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
k8s.io/api/discovery: remove API docs referencing EndpointSliceTermin…
219300c 
…atingCondition feature gate

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
pkg/controller/endpointslice: remove all references to the EndpointSl…
e282b6c 
…iceTerminatingCondition feature gate

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
pkg/registry/discovery: remove references to EndpointSliceTerminating…
5ca805f 
…Condition feature gate when dropping disabled fields

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
test/integration/endpointslice: remove references to EndpointSliceTer…
9e24680 
…minatingCondition feature gate

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2022
@andrewsykim
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2022
@andrewsykim
Copy link
Member Author

/retest

@aojea
Copy link
Member

aojea commented Nov 4, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit b20ddbd into kubernetes:master Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@thockin thockin thockin left review comments

@aojea aojea Awaiting requested review from aojea

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@robscott robscott

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andrewsykim @k8s-triage-robot @leilajal @aojea @thockin @robscott @k8s-ci-robot