Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graduate RetroactiveDefaultStorageClass to beta #113329

Merged
merged 2 commits into from Nov 2, 2022
Merged

graduate RetroactiveDefaultStorageClass to beta #113329

merged 2 commits into from Nov 2, 2022

Conversation

RomanBednar
Copy link
Contributor

Change feature to beta and remove e2e test feature flags since they're not needed anymore.

What type of PR is this?

/kind feature

What this PR does / why we need it:

RetroactiveDefaultStorageClass is planned to graduate to beta in 1.26.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Here are the criteria for beta graduation required by this KEP.

  1. Scalability tests with existing framework: Retroactive default StorageClass assignement  enhancements#3333 (comment)
  2. Manually test version skew between the API server and KCM: Retroactive default StorageClass assignement  enhancements#3333 (comment)
  3. Manually test upgrade->downgrade->upgrade path: Retroactive default StorageClass assignement  enhancements#3333 (comment)
  4. Metrics: add a metric for retroactive sc errors #113323

Does this PR introduce a user-facing change?

RetroactiveDefaultStorageClass feature is now beta.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3333

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 25, 2022
@k8s-ci-robot
Copy link
Contributor

@RomanBednar: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 25, 2022
@RomanBednar RomanBednar mentioned this pull request Oct 25, 2022
Merged
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2022
@RomanBednar
Copy link
Contributor Author

/retest

@rhockenbury rhockenbury mentioned this pull request Oct 29, 2022
Open
12 tasks
@jsafrane
Copy link
Member

/assign

@liggitt liggitt removed their request for review October 31, 2022 12:32
@jsafrane
Copy link
Member

@RomanBednar and now you need to fix the tests

@jsafrane
Copy link
Member

/test pull-kubernetes-integration
that looks like a flake

@RomanBednar
graduate RetroactiveDefaultStorageClass to beta
8209066 
Change feature to beta and remove e2e test feature flags since they're
not needed anymore.
@RomanBednar
fix unit tests
8d48c10
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2022
@jsafrane
Copy link
Member

jsafrane commented Nov 2, 2022

/lgtm
/approve
/retest-required

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@jsafrane
Copy link
Member

jsafrane commented Nov 2, 2022

/assign @thockin
For approval, you approved validation changes in the alpha phase in #111467

@dims
Copy link
Member

dims commented Nov 2, 2022

/assign @liggitt

(adding Jordan as well)

@liggitt
Copy link
Member

liggitt commented Nov 2, 2022

/approve

@liggitt liggitt added this to API review completed, 1.26 in API Reviews Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, liggitt, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 06ba383 into kubernetes:master Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 2, 2022
@RomanBednar RomanBednar mentioned this pull request Nov 10, 2022
Merged
@RomanBednar RomanBednar mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

Assignees

@liggitt liggitt

@jsafrane jsafrane

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.26
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RomanBednar @k8s-ci-robot @jsafrane @dims @liggitt @thockin