New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire up feature enablement metric in feature_gate.go #112690
Conversation
9400ea7
to
fb4828f
Compare
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/retest |
fb4828f
to
50d0a09
Compare
dc238d3
to
154d0c7
Compare
154d0c7
to
80b4b9e
Compare
Change-Id: Idfbc9e72f1e0051a9423b23d1f0397364bb3c251
/lgtm |
/retest |
2 similar comments
/retest |
/retest |
/triage accepted |
Isn't this a feature? Why is it not a feature? |
We do not mandate KEPs to add metrics, i.e. this is not a feature. This is a metric that tells you if a feature is enabled. Furthermore, this is an already mandated question of production readiness review. |
Can I suggest this tweak to the release note? Add `kubernetes_feature_enabled` metric series to track whether each active feature gate is enabled. |
Sure thing. |
@logicalhan @liggitt GA stage is represented as empty?
EDIT This is really cool by the way, nice to have this exposed via metrics |
Thanks! Yeah I dig it too :)
Yeah, that's a result of this: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/featuregate/feature_gate.go#L80-L82 |
I was thinking of it more for the release announcement, etc. This seems really useful to users. |
Ah, okay. Yeah would be happy to announce it as a feature. I also agree this will be extremely useful to our users, it feels very much an obvious thing to do in retrospect. |
This will be included in the Major Themes for the v1.26 release blog. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This change allows us to track feature enablement generically.
This is the output of the metric for apiserver using
local-up-cluster.sh
: