Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: skip health rules if they are a subnet of the client rule #112267

Merged
merged 1 commit into from Sep 15, 2022
Merged

aws: skip health rules if they are a subnet of the client rule #112267

merged 1 commit into from Sep 15, 2022

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Sep 6, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

See merged cloud-provider-aws PR kubernetes/cloud-provider-aws#437

Does this PR introduce a user-facing change?

Services of type LoadBalancer create fewer AWS security group rules in most cases

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

@sjenning: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 6, 2022
@sjenning
Copy link
Contributor Author

sjenning commented Sep 6, 2022

cc @deads2k @derekwaynecarr

@sjenning
Copy link
Contributor Author

sjenning commented Sep 6, 2022

cc @JoelSpeed

@deads2k
Copy link
Contributor

deads2k commented Sep 6, 2022

This corrects a problem where scarce security group rules are inefficiently allocated.

@sjenning
Copy link
Contributor Author

sjenning commented Sep 6, 2022

cc @micahhausler @M00nF1sh

@deads2k
Copy link
Contributor

deads2k commented Sep 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@nckturner
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9cd6331 into kubernetes:master Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 15, 2022
This was referenced Sep 16, 2022
Merged
Merged
@sjenning sjenning mentioned this pull request Sep 20, 2022
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 20, 2022
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjenning @k8s-ci-robot @deads2k @nckturner