Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add meta-metrics for metrics framework #112907

Merged
merged 4 commits into from Oct 7, 2022
Merged

add meta-metrics for metrics framework #112907

merged 4 commits into from Oct 7, 2022

Conversation

logicalhan
Copy link
Member

@logicalhan logicalhan commented Oct 7, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a metric showing the number of metrics broken down by stability level and deprecated version.

# HELP registered_metric_total [ALPHA] The count of registered metrics broken by stability level and deprecation version.
# TYPE registered_metric_total counter
registered_metric_total{deprecated_version="",stability_level="ALPHA"} 150
registered_metric_total{deprecated_version="",stability_level="STABLE"} 10

Special notes for your reviewer:

Does this PR introduce a user-facing change?

`registered_metric_total` now reports the number of metrics broken down by stability level and deprecated version

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/3466

@logicalhan
add meta-metrics for metrics framework
1b74ea0 
Change-Id: I15c2947e910419e6cb07db22a40fc0667fcd128b
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

@logicalhan: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2022
@logicalhan
remove unused code
3cad84b 
Change-Id: Id46edb8bbcd043288a4c38692dcf99dd6d34fa1c
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2022
@logicalhan
move automatic registration of meta-metrics to legacy registry
e3a1d6c 
Change-Id: I06608184db62b3e893efc0c0a42963f9ffaaf677
YoyinZyc
YoyinZyc reviewed Oct 7, 2022
View reviewed changes
staging/src/k8s.io/component-base/metrics/metric.go Outdated
if deprecatedV != nil {
dv = deprecatedV.String()
}
defer registeredMetrics.WithLabelValues(string(sl), dv).Inc()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question. Why use defer here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that was from a move, i don't think it matters in this exact spot in practice.

@logicalhan
remove defer
1b3c346 
Change-Id: Idbe0ee3349f91ea58a15be4eb9d3892c3e6a3693
@YoyinZyc
Copy link
Contributor

YoyinZyc commented Oct 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 609bf91 into kubernetes:master Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 7, 2022
@logicalhan logicalhan mentioned this pull request Oct 13, 2022
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoyinZyc YoyinZyc YoyinZyc left review comments

@coffeepac coffeepac Awaiting requested review from coffeepac

Assignees

@YoyinZyc YoyinZyc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@logicalhan @k8s-ci-robot @YoyinZyc