New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add meta-metrics for metrics framework #112907
add meta-metrics for metrics framework #112907
Conversation
Change-Id: I15c2947e910419e6cb07db22a40fc0667fcd128b
@logicalhan: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change-Id: Id46edb8bbcd043288a4c38692dcf99dd6d34fa1c
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change-Id: I06608184db62b3e893efc0c0a42963f9ffaaf677
if deprecatedV != nil { | ||
dv = deprecatedV.String() | ||
} | ||
defer registeredMetrics.WithLabelValues(string(sl), dv).Inc() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a question. Why use defer
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that was from a move, i don't think it matters in this exact spot in practice.
Change-Id: Idbe0ee3349f91ea58a15be4eb9d3892c3e6a3693
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a metric showing the number of metrics broken down by stability level and deprecated version.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: