Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no kubernetes CI unit test machine for Windows #51540

Closed
JiangtianLi opened this issue Aug 29, 2017 · 70 comments
Closed

There is no kubernetes CI unit test machine for Windows #51540

JiangtianLi opened this issue Aug 29, 2017 · 70 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@JiangtianLi
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:
Currently there is no kubernetes CI unit test machine for Windows. Since the Windows features in kubernetes are growing fast, it is important to set up the Windows CI jenkins test on kubernetes, to prevent build failure and unit test failure for Windows.

What you expected to happen:
kubernetes CI unit test machine is set up for Windows.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 29, 2017
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 29, 2017
@JiangtianLi JiangtianLi mentioned this issue Aug 29, 2017
Closed
@cmluciano
Copy link

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 29, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 29, 2017
@cmluciano
Copy link

@kubernetes/sig-testing-feature-requests

@jdumars
Copy link
Member

jdumars commented Aug 29, 2017

/sig azure
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/azure sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Aug 29, 2017
@andyzhangx
Copy link
Member

actually there is /test pull-kubernetes-cross which will do build test for linux/windows/darwin, but by default it's not open

@yujuhong
Copy link
Contributor

yujuhong commented Sep 9, 2017

Does kubernetes even build natively on windows?

@yujuhong yujuhong mentioned this issue Sep 9, 2017
Merged
@JiangtianLi
Copy link
Contributor Author

@yujuhong We build kubernetes windows binary on linux. This issue is about be able to run unit test that requires windows. @andyzhangx is working on Azure file/Azure disk and the ask here is to have unit test pass besides build pass.

@0xmichalis
Copy link
Contributor

actually there is /test pull-kubernetes-cross which will do build test for linux/windows/darwin, but by default it's not open

This job will run for every PR that touches any file with a name that satisfies this regexp.

@yujuhong
Copy link
Contributor

@JiangtianLi I asked because then you need one job to cross compile the binary, and another job to run tests on Windows. I don't know if this is currently supported by our test framework.

@jdumars
Copy link
Member

jdumars commented Dec 26, 2017

@JiangtianLi do we need to pull this work forward into 1.10 / SIG-Azure?

@yujuhong
Copy link
Contributor

@JiangtianLi do we need to pull this work forward into 1.10 / SIG-Azure?

+1
Would really like to see some CI tests for windows

@JiangtianLi
Copy link
Contributor Author

@jdumars Please add this to 1.10 sig azure and drive forward. This would definitely benefit development on Windows platform.

@jdumars
Copy link
Member

jdumars commented Dec 27, 2017

Acknowledged.

@feiskyer feiskyer added this to the v1.10 milestone Dec 28, 2017
@feiskyer
Copy link
Member

@JiangtianLi @jdumars Added to v1.10 milestone.

@krzyzacy
Copy link
Member

this probably should be sig-azure implementing some provider interface within kubetest, similar with sig-aws did?

https://github.com/kubernetes/test-infra/blob/master/kubetest/kops.go
and
https://github.com/kubernetes/test-infra/blob/master/kubetest/gke.go
are good references.

@jberkus
Copy link

jberkus commented Feb 19, 2018

adding priority so that we can keep tracking this for 1.10, please update.

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 19, 2018
@jdumars
Copy link
Member

jdumars commented Feb 21, 2018

I am bumping this from 1.10. Let's get this sorted in 1.11 and get SIG Azure on the case. cc: @khenidak

@jdumars jdumars modified the milestones: v1.10, v1.11 Feb 21, 2018
@feiskyer feiskyer mentioned this issue Feb 24, 2018
Open
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2022
@jsturtevant
Copy link
Contributor

I think we can close this. We have the ability to run the tests and have a job now. We are tracking the improvements to make all the unit tests pass in separate PRs. You can find them searching for unittest on our sig-windows dashboard https://github.com/orgs/kubernetes/projects/99/views/1

/close

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Closing this issue.

In response to this:

I think we can close this. We have the ability to run the tests and have a job now. We are tracking the improvements to make all the unit tests pass in separate PRs. You can find them searching for unittest on our sig-windows dashboard https://github.com/orgs/kubernetes/projects/99/views/1

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 18, 2022
Merged
Closed
@claudiubelu claudiubelu mentioned this issue Nov 25, 2022
Open
This was referenced Dec 7, 2022
Merged
Merged
Merged
Closed
This was referenced Dec 15, 2022
Merged
Open
@claudiubelu claudiubelu mentioned this issue Jan 2, 2023
Merged
@claudiubelu claudiubelu mentioned this issue Jan 10, 2023
Merged
This was referenced Jan 11, 2023
Merged
Merged
This was referenced Feb 21, 2023
Merged
Merged
This was referenced Mar 14, 2023
Merged
Merged
Merged
Merged
@claudiubelu claudiubelu mentioned this issue Apr 6, 2023
Merged
@claudiubelu claudiubelu mentioned this issue Apr 26, 2023
Merged
@claudiubelu claudiubelu mentioned this issue Jul 19, 2023
Merged
@claudiubelu claudiubelu mentioned this issue Jan 20, 2024
Merged
This was referenced Apr 18, 2024
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-windows] Issue Tracking
Status: Done
Milestone
No milestone
Development

No branches or pull requests