Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kubectl display of invalid errors #112150

Merged
merged 1 commit into from Aug 31, 2022
Merged

Improve kubectl display of invalid errors #112150

merged 1 commit into from Aug 31, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 31, 2022 •
edited

What type of PR is this?

/kind bug
/kind regression
/sig cli

What this PR does / why we need it:

Improves how kubectl displays invalid errors returned by the server.

Which issue(s) this PR fixes:

Fixes #111108

Does this PR introduce a user-facing change?

Fix 1.23 regression in kubectl display of invalid request errors returned by the API server

/cc @akutz @nikhita

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. sig/cli Categorizes an issue or PR as relevant to SIG CLI. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2022
@liggitt liggitt mentioned this pull request Aug 31, 2022
Closed
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2022
This was referenced Aug 31, 2022
Merged
Merged
Merged
@seans3
Copy link
Contributor

seans3 commented Aug 31, 2022

/lgtm
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 31, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2022
aruneshpa
aruneshpa approved these changes Aug 31, 2022
View reviewed changes
Copy link

@aruneshpa aruneshpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

akutz
akutz approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@akutz akutz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liggitt! We have confirmed it works as expected on our end. The webhook errors are now propogating back through to the user via kubectl. Thank you so much for the quick turnaround!

/lgtm

soltysh
soltysh approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akutz, aruneshpa, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2779326 into kubernetes:master Aug 31, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 31, 2022
k8s-ci-robot added a commit that referenced this pull request Sep 1, 2022
@k8s-ci-robot
Merge pull request #112154 from liggitt/automated-cherry-pick-of-#112…
40ce92c 
…150-upstream-release-1.25

Automated cherry pick of #112150: Improve kubectl display of invalid errors
k8s-ci-robot added a commit that referenced this pull request Sep 1, 2022
@k8s-ci-robot
Merge pull request #112155 from liggitt/automated-cherry-pick-of-#112…
8610544 
…150-upstream-release-1.24

Automated cherry pick of #112150: Improve kubectl display of invalid errors
k8s-ci-robot added a commit that referenced this pull request Sep 1, 2022
@k8s-ci-robot
Merge pull request #112156 from liggitt/automated-cherry-pick-of-#112…
c141fb9 
…150-upstream-release-1.23

Automated cherry pick of #112150: Improve kubectl display of invalid errors
@liggitt liggitt mentioned this pull request Nov 7, 2022
Merged
@liggitt liggitt deleted the kubectl-invalid branch November 26, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akutz akutz akutz approved these changes

@soltysh soltysh soltysh approved these changes

@aruneshpa aruneshpa aruneshpa approved these changes

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

kubectl: non-helpful error for 422 webhook status with no Reason field
6 participants
@liggitt @seans3 @k8s-ci-robot @akutz @soltysh @aruneshpa