New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for runtime endpoint flag #112542
Conversation
cf8c578
to
d070ffd
Compare
/kind feature /release-note Added validation for the --container-runtime-endpoint flag of kubelet to be non-empty. |
495978a
to
10bfa1f
Compare
/assign @sjenning |
10bfa1f
to
805be30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astraw99, mrunalp, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… several comments Signed-off-by: Paco Xu <paco.xu@daocloud.io>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add validation to make the error msg more clearly, and also updated the CRI support error msg.
Which issue(s) this PR fixes:
Fixes #112541
Does this PR introduce a user-facing change?