New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not print status stack in case of timeout from timeout handler #112374
Conversation
Hi @Argh4k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
6e0cacf
to
886648b
Compare
/retest |
this looks reasonable/safe to me... would like another api-machinery ack (@deads2k would be a good candidate) |
nice cleanup /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Argh4k, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR removes printing of stack trace in case we timeout the reqeust via timeout handler. When we timeout a request via timeout handler stacktrace will always point to timeout.go, adding no real value for debugging. Size of each stack trace is around 8kB, effectively cluttering logs and taking logger for quite a long time compared to other logging outputs, which can be undesirable when the apiserver is overloaded (which is very likely, when we timeout requests). I do not want to turn off completely status stack logging in case of timeout, as we can return timeout via normal handler if some operations inside it times out.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: