kubeadm: support image repository format validation #112732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/kubeadm
approved
neolit123
reviewed
Sep 26, 2022
neolit123
reviewed
Sep 26, 2022
k8s-ci-robot
added
triage/accepted
SataQiu
force-pushed
the
fix-kubeadm-20220926
branch
from
612d20a
to
3ce5e92
Compare
SataQiu
force-pushed
the
fix-kubeadm-20220926
branch
from
3ce5e92
to
b833e62
Compare
neolit123
reviewed
Sep 26, 2022
neolit123
reviewed
Sep 26, 2022
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
Let's wait for more review |
|
/lgtm BTW, should we backport it to old releases so that CAPI can benefit from this with earlier releases? |
well, technically it does not qualify for a backport because it is an improvement / feature and not a blocking bug fix. |
|
it seems good to go |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubeadm: support image repository format validation
Sample output：
./kubeadm init --config /tmp/kubeadm.config.yaml --dry-run dns.imageRepository: Invalid value: "registry.contoso.com/kubernetes\n s\n": invalid image repository formatWhich issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2758
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: