New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: support image repository format validation #112732
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
thanks @SataQiu
612d20a
to
3ce5e92
Compare
3ce5e92
to
b833e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
please cancel the hold if this is good to go
Let's wait for more review |
/lgtm BTW, should we backport it to old releases so that CAPI can benefit from this with earlier releases? |
well, technically it does not qualify for a backport because it is an improvement / feature and not a blocking bug fix. |
it seems good to go |
What type of PR is this?
/kind feature
What this PR does / why we need it:
kubeadm: support image repository format validation
Sample output:
./kubeadm init --config /tmp/kubeadm.config.yaml --dry-run dns.imageRepository: Invalid value: "registry.contoso.com/kubernetes\n s\n": invalid image repository format
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2758
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: