Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update images, dependencies and version to Go 1.19.1 #112287

Merged
merged 5 commits into from Sep 8, 2022
Merged

Update images, dependencies and version to Go 1.19.1 #112287

merged 5 commits into from Sep 8, 2022

Conversation

palnabarun
Copy link
Member

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • Bump kube-cross, go-runner image to Go 1.19.1 based ones
  • Bump test Makefile to Go 1.19.1
  • Bump default go version for publishing bot to 1.19.1

Which issue(s) this PR fixes:

Part of kubernetes/release#2658

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Go 1.19.1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

/sig release
/cc @kubernetes/release-engineering

@palnabarun
Update kube-cross version to v1.25.0-go1.19.1-bullseye.0
242649e 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
update the default go-runner version to v2.3.1-go1.19.1-bullseye.0
854b50e 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Update publishing bot default Go version to 1.19.1
b4ac3b1 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Update Go version in test Makefile to 1.19.1
26b3324 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Updates dependencies to reflect Go version updates to 1.19.1
fd3d116 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

@palnabarun: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 7, 2022
@palnabarun palnabarun added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 7, 2022
@palnabarun
Copy link
Member Author

palnabarun commented Sep 7, 2022 •
edited

Note: The PR should be merged only after the relevant images have been promoted. The tests would fail before that. Do not retry the tests.

Some images have been promoted!
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-image-promo/1567583644514521088

Remaining:

@palnabarun palnabarun mentioned this pull request Sep 7, 2022
Closed
21 tasks
@palnabarun
Copy link
Member Author

/retest

@palnabarun palnabarun changed the title [DO NOT MERGE] Update images, dependencies and version to Go 1.19.1 Update images, dependencies and version to Go 1.19.1 Sep 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022
@palnabarun
Copy link
Member Author

/retest

@ameukam
Copy link
Member

ameukam commented Sep 8, 2022

/assign @dims

@dims
Copy link
Member

dims commented Sep 8, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, palnabarun, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0e54bd2 into kubernetes:master Sep 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 8, 2022
@Dentrax Dentrax mentioned this pull request Sep 24, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@palnabarun @k8s-ci-robot @ameukam @dims @saschagrunert