New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promote the Portworx feature gate to Beta #110411
Conversation
@trierra: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @trierra. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig storage |
PVC resize test:
|
e2e test results
|
Storage class info
|
pkg/features/kube_features.go
Outdated
@@ -145,7 +145,7 @@ const ( | |||
CSIMigrationOpenStack featuregate.Feature = "CSIMigrationOpenStack" | |||
|
|||
// owner: @trierra | |||
// alpha: v1.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this line about alpha.
/ok-to-test |
Please add a release note. |
/milestone v1.25 |
done |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, trierra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit "Promote CSI driver migration (from Portworx file in-tree drive), to beta" |
/release-note-edit "Promote CSI driver migration (from Portworx file in-tree driver), to beta" |
(did that work?) |
@trierra Can you add a deprecation notice in the release note section of your PR? See the release note section in the following PR when GCE CSI Migration was moved to Beta (off-by-default) and the in-tree GCE PD plugin "kubernetes.io/gce-pd" was deprecated in 1.17: |
@xing-yang done |
Thanks @trierra. Can you change "will be removed in 1.27" to "will be removed in a future release"? This is a more likely timeline: |
@xing-yang done! |
What type of PR is this?
/kind feature
What this PR does / why we need it:
To promote the CSIMigrationPortworx feature to Beta
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig-storage