Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CVE-2022-27664 Bump golang.org/x/net to v0.1.1-0.20221027164007-c63010009c80 #112693

Merged
merged 1 commit into from Oct 28, 2022
Merged

Fixed CVE-2022-27664 Bump golang.org/x/net to v0.1.1-0.20221027164007-c63010009c80 #112693

merged 1 commit into from Oct 28, 2022

Conversation

aimuz
Copy link
Contributor

@aimuz aimuz commented Sep 23, 2022 •
edited

Signed-off-by: aimuz mr.imuz@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

fix https://pkg.go.dev/vuln/GO-2022-0969

Fixes #112758

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump golang.org/x/net to v0.1.1-0.20221027164007-c63010009c80

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver area/cloudprovider area/code-generation do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/dependency Issues or PRs related to dependency changes needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @aimuz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, aojea and a team September 23, 2022 03:28
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Sep 23, 2022
@aimuz
Copy link
Contributor Author

aimuz commented Sep 23, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@aimuz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aimuz aimuz changed the title Bump golang.org/x/net to v0.0.0-20220921203646-d300de134e69 Fixed CVE-2022-27664 Bump golang.org/x/net to v0.0.0-20220921203646-d300de134e69 Sep 23, 2022
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 28, 2022
@aimuz aimuz changed the title Fixed CVE-2022-27664 Bump golang.org/x/net to d300de134e69 Fixed CVE-2022-27664 Bump golang.org/x/net to v0.1.1-0.20221027164007-c63010009c80 Oct 28, 2022
@aimuz
Copy link
Contributor Author

aimuz commented Oct 28, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2022
@aimuz
Copy link
Contributor Author

aimuz commented Oct 28, 2022

Upstream work is done, this PR can continue

@aimuz
Copy link
Contributor Author

aimuz commented Oct 28, 2022

/test pull-kubernetes-unit

@aimuz
Copy link
Contributor Author

aimuz commented Oct 28, 2022

/test pull-kubernetes-e2e-capz-windows-containerd

@liggitt
Copy link
Member

liggitt commented Oct 28, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aimuz
Copy link
Contributor Author

aimuz commented Oct 28, 2022

Do you need a cherry pick for this?

@aimuz aimuz mentioned this pull request Oct 28, 2022
Merged
@k8s-ci-robot k8s-ci-robot merged commit 6cb473b into kubernetes:master Oct 28, 2022
SIG Auth Old automation moved this from Needs Triage to Closed / Done Oct 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 28, 2022
@pacoxu pacoxu mentioned this pull request Oct 28, 2022
Closed
9 tasks
@aimuz aimuz mentioned this pull request Oct 31, 2022
Merged
@cpanato
Copy link
Member

cpanato commented Nov 1, 2022

@aimuz @liggitt the cherry pick is only needed for 1.25/1.24?

@liggitt
Copy link
Member

liggitt commented Nov 1, 2022

I don't see a reason we wouldn't pick this to 1.23 as well (it will likely result in bumps to other golang.org/x/... deps as well)

@aimuz
Copy link
Contributor Author

aimuz commented Nov 1, 2022 •
edited

#113425 (comment)

https://pkg.go.dev/vuln/GO-2022-0969

According to @xmudrii description, in 1.23 using go1.17 compilation, in the vulnerability description, go 1.18.6 before the version of the standard library net/http also has the problem, if in 1.23 cherry-pick past, may not be able to completely solve the problem, next, I will try to first this pr cherry-pick to 1.23, I will verify him in the 1.17 version of go

@xmudrii
Copy link
Member

xmudrii commented Nov 1, 2022

@aimuz Reading the vulnerability report that you linked, it seems like updating the /x/net library in 1.23 would be helpful. We can't do anything about net/http, but we can try to bump /x/net so that we're safe(r) on that side at least.

@aimuz aimuz mentioned this pull request Nov 2, 2022
Closed
@chaunceyjiang chaunceyjiang mentioned this pull request Nov 9, 2022
Closed
k8s-ci-robot added a commit that referenced this pull request Nov 16, 2022
@k8s-ci-robot
Merge pull request #113425 from aimuz/automated-cherry-pick-of-#11269…
c8d0fbe 
…3-upstream-release-1.25

Automated cherry pick of #112693: Fixed (CVE-2022-27664) Bump golang.org/x/net to
k8s-ci-robot added a commit that referenced this pull request Nov 16, 2022
@k8s-ci-robot
Merge pull request #113459 from aimuz/automated-cherry-pick-of-#11269…
d818028 
…3-upstream-release-1.24

Automated cherry pick of #112693: Fixed (CVE-2022-27664) Bump golang.org/x/net to
@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aojea aojea Awaiting requested review from aojea

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Done
SIG Auth Old
Closed / Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

net package used by kubernetes vulnerable to CVE-2022-27664
9 participants
@aimuz @k8s-ci-robot @dims @liggitt @k8s-triage-robot @fedebongio @cpanato @xmudrii @smarterclayton