Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(kubectl patch): Add descriptive message when patch type is unsupported #112556

Merged
merged 1 commit into from Sep 20, 2022
Merged

(kubectl patch): Add descriptive message when patch type is unsupported #112556

merged 1 commit into from Sep 20, 2022

Conversation

ardaguclu
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

kubectl patch commands fails when patch type is strategic merge patch for CRDs. This PR handles UnsupportedMediaType error and shows descriptive message to user.

Example error:

error: application/strategic-merge-patch+json is not supported by samplecontroller.k8s.io/v1alpha1, Kind=Foo: the body of the request was in an unknown format - accepted media types include: application/json-patch+json, application/merge-patch+json, application/apply-patch+yaml

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1280

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Change error message when resource is not supported by given patch type in kubectl patch

@ardaguclu
(kubectl patch): Add descriptive message when patch type is unsupported
dc2c0ad 
`kubectl patch` commands fails when patch type is strategic merge
patch for CRDs. This PR handles `UnsupportedMediaType` error and
shows descriptive message to user.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 19, 2022
@ardaguclu
Copy link
Member Author

/cc @apelisse @MikeSpreitzer
could you PTAL?. Thanks.

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2022
@ardaguclu
Copy link
Member Author

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 19, 2022
@apelisse
Copy link
Member

Looks good to me, but I'll let Mike give his opinion.
We also need to find a good spot to document that in the website.

Thanks!

@ardaguclu
Copy link
Member Author

AFAICS, this PR #112466 covers website changes.

MikeSpreitzer
MikeSpreitzer approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@MikeSpreitzer MikeSpreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@apelisse
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, ardaguclu, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6ee3cbd into kubernetes:master Sep 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 20, 2022
@ardaguclu ardaguclu deleted the patch-smp-error-msg branch September 20, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

@apelisse apelisse Awaiting requested review from apelisse

@dougsland dougsland Awaiting requested review from dougsland

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees

@apelisse apelisse

@MikeSpreitzer MikeSpreitzer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

kubectl fails to apply strategic merge patch to custom resource
4 participants
@ardaguclu @apelisse @k8s-ci-robot @MikeSpreitzer