Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #114914: Adjust DisruptionTarget condition message to do not include #114945

Merged
merged 1 commit into from Jan 12, 2023
Merged

Automated cherry pick of #114914: Adjust DisruptionTarget condition message to do not include #114945

merged 1 commit into from Jan 12, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jan 10, 2023 •
edited by liggitt

Cherry pick of #114914 on release-1.26.

#114914: Adjust DisruptionTarget condition message to do not include

For details on the cherry pick process, see the cherry pick requests page.

Fix a regression in default 1.26 configurations with the PodDisruptionConditions feature enabled where preemptor pod metadata can be included in the message of DisruptionTarget condition

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

@mimowo: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 10, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Jan 10, 2023

/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 10, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Jan 10, 2023

/retest

@alculquicondor
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 796fa0b8df83bbaed913967bcf2169609eb3e225

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@alculquicondor
Copy link
Member

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team January 10, 2023 18:04
@Verolop
Copy link

Verolop commented Jan 11, 2023

hi @mimowo are you planning to backport this for 1.25 & 1.24 too?
thanks!

@Verolop
Copy link

Verolop commented Jan 12, 2023

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 12, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Jan 12, 2023

hi @mimowo are you planning to backport this for 1.25 & 1.24 too?
thanks!

hi @Verolop , the feature was alpha in 1.25, so no need. It didn't exist in 1.24.

@Verolop
Copy link

Verolop commented Jan 12, 2023

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5d3c413 into kubernetes:release-1.26 Jan 12, 2023
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Jan 30, 2023
@mimowo mimowo deleted the automated-cherry-pick-of-#114914-upstream-release-1.26 branch March 18, 2023 18:37
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave Awaiting requested review from chendave

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@alculquicondor alculquicondor

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mimowo @k8s-ci-robot @alculquicondor @Verolop @liggitt