New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of KEP-3335, StatefulSetSlice #112744
Add implementation of KEP-3335, StatefulSetSlice #112744
Conversation
Hi @pwschuurman. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-sig api-machinery |
b06581b
to
fa95137
Compare
fa95137
to
54aa16c
Compare
13f5b85
to
a8131fa
Compare
For the release note, I suggest Added a feature that allows a StatefulSet to start numbering replicas from an arbitrary non-negative ordinal, using the `.spec.replicaStartOrdinal` field. |
Thanks for the suggestion. Updated here and in kubernetes/enhancements#3335 |
/remove-sig api-machinery |
99c5abe
to
9258cb4
Compare
/assign @smarterclayton |
/assign @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
// to number replicas from an alternate index (eg: 1-indexed) over the default | ||
// 0-indexed names, or to orchestrate progressive movement of replicas from | ||
// one StatefulSet to another. | ||
// If set, replica indices will be in the range: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great examples
just the one comment |
11caabb
to
43c9d1a
Compare
43c9d1a
to
c492a6d
Compare
Thanks @smarterclayton, addressed this comment in the PR |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman, smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Exception request submitted by @pwschuurman has been accepted by the release team! Your updated deadline to make any changes to your PR is 18:00 PST Thursday 10th November 2022. /milestone v1.26 |
@@ -128,6 +130,12 @@ func ValidateStatefulSetSpec(spec *apps.StatefulSetSpec, fldPath *field.Path, op | |||
|
|||
allErrs = append(allErrs, apivalidation.ValidateNonnegativeField(int64(spec.Replicas), fldPath.Child("replicas"))...) | |||
allErrs = append(allErrs, apivalidation.ValidateNonnegativeField(int64(spec.MinReadySeconds), fldPath.Child("minReadySeconds"))...) | |||
if utilfeature.DefaultFeatureGate.Enabled(features.StatefulSetStartOrdinal) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not be checking feature gates here... if the field is non-nil, always validate it
please open a PR to fix this and backport it to 1.26 ahead of beta promotion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment applies to other things in the validation.go file checking feature enablement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching. Opened #116025 to track fix and 1.26 backport.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: