Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update preemption victims metric #112939

Merged
merged 1 commit into from Oct 13, 2022
Merged

feat: update preemption victims metric #112939

merged 1 commit into from Oct 13, 2022
+9 −12

Conversation

lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Oct 9, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

We should have more visibility around average number of preemptions. It's not possible to see if pods require less than 5 preemptions to inform how expensive preemption is for a certain QPS.

Which issue(s) this PR fixes:

Fixes # #112912

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Change  `preemption_victims` metric bucket from `LinearBuckets` to `ExponentialBuckets`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 9, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lengrongfu / name: rongfu.leng (8cdccd004f2218a782e742df9f6e416ec07ab6c7)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 9, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2022
@k8s-ci-robot
Copy link
Contributor

@lengrongfu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lengrongfu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2022
@lengrongfu lengrongfu force-pushed the feat/update_preemption_victims_metric branch 2 times, most recently from f23958e to 8cdccd0 Compare October 9, 2022 07:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 9, 2022
@k8s-ci-robot
Copy link
Contributor

@lengrongfu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chendave
Copy link
Member

chendave commented Oct 9, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2022
@lengrongfu lengrongfu force-pushed the feat/update_preemption_victims_metric branch from 8cdccd0 to e099b76 Compare October 9, 2022 14:01
@k8s-ci-robot k8s-ci-robot added the area/stable-metrics Issues or PRs involving stable metrics label Oct 9, 2022
@lengrongfu
Copy link
Contributor Author

/retest

@k8s-triage-robot
Copy link

This PR may require stable metrics review.

Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines.

yangjunmyfm192085
yangjunmyfm192085 reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022
@yangjunmyfm192085
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 10, 2022
@yangjunmyfm192085
Copy link
Contributor

/release-note

@k8s-ci-robot
Copy link
Contributor

@yangjunmyfm192085: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yangjunmyfm192085
Copy link
Contributor

we have a user-facing change, maybe we need to add release-note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 10, 2022
@lengrongfu
Copy link
Contributor Author

we have a user-facing change, maybe we need to add release-note

Done.

@yangjunmyfm192085
Copy link
Contributor

/assign @alculquicondor @logicalhan

logicalhan
logicalhan approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@lengrongfu lengrongfu force-pushed the feat/update_preemption_victims_metric branch from e099b76 to b2a5def Compare October 12, 2022 16:25
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2022
@lengrongfu
feat: update preemption victims metric
8dcd869 
Signed-off-by: lengrongfu <rongfu.leng@daocloud.io>
@lengrongfu lengrongfu force-pushed the feat/update_preemption_victims_metric branch from b2a5def to 8dcd869 Compare October 13, 2022 18:45
@alculquicondor
Copy link
Member

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, lengrongfu, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
yangjunmyfm192085
yangjunmyfm192085 reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@k8s-ci-robot k8s-ci-robot merged commit 040d7aa into kubernetes:master Oct 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 13, 2022
@pacoxu pacoxu mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@logicalhan logicalhan logicalhan approved these changes

@chendave chendave Awaiting requested review from chendave

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@logicalhan logicalhan

@alculquicondor alculquicondor

@yangjunmyfm192085 yangjunmyfm192085

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/stable-metrics Issues or PRs involving stable metrics cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lengrongfu @k8s-ci-robot @chendave @k8s-triage-robot @yangjunmyfm192085 @alculquicondor @logicalhan