Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote CSIMigrationAWS to GA #111479

Merged
merged 2 commits into from Aug 1, 2022
Merged

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jul 27, 2022

What type of PR is this?

/kind feature

/sig storage

What this PR does / why we need it:

CSIMigrationAWS has been beta since 1.17, on by default since 1.23, this takes it to GA for 1.25.
kubernetes/enhancements#1487

Which issue(s) this PR fixes:

Special notes for your reviewer:

I am still working on Windows and upgrade tests, aim to complete this week but opening the PR now as placeholder.

Testing:


MISC NOTES FOR SELF (sorry, I am editing this PR frequently with notes/progress so to keep above checklist comprehensible dumping stuff here):

Disable migration means:

cloudProvider: aws
featureGates:
  CSIMigration: "false"
  CSIMigrationAWS: "false"

Windows test
./_output/bin/e2e.test --ginkgo.focus="aws.*ntfs" \ --ginkgo.skip="LinuxOnly|expand" \ --kubeconfig=$HOME/.kube/config \ --node-os-distro=windows \ --gce-zone=us-west-2a \ --provider=aws

{"msg":"FAILED [sig-storage] In-tree Volumes [Driver: aws] [Testpattern: Dynamic PV (ntfs)][Feature:Windows] subPath should support creating multiple subpathfrom same volumes [Slow]","completed":19,"skipped":6573,"failed":1,"failures":["[sig-storage] In-tree Volumes [Driver: aws] [Testpattern: Dynamic PV (ntfs)][Feature:Windows] subPath should support creating multiple subpath from same volumes [Slow]"]}~

Does this PR introduce a user-facing change?

CSIMigrationAWS upgraded to GA and locked to true.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2022
@wongma7 wongma7 changed the title WIP: Promote CSIMigrationAWS to GA Promote CSIMigrationAWS to GA Jul 29, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2022
@wongma7
Copy link
Contributor Author

wongma7 commented Jul 29, 2022

Ready for review, CI tests passing now. Since my windows test turned out basically like a superset of upgrade test (upgrading EKS from 1.22->1.23) I think it's sufficient, however I'm still going to work on repeating the test for a kops 1.25 cluster without involving Windows and the checklist reflects this

@xing-yang
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 1, 2022
@xing-yang
Copy link
Contributor

/assign @gnufied @jsafrane

@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 1, 2022
@gnufied
Copy link
Member

gnufied commented Aug 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@xing-yang
Copy link
Contributor

/lgtm
/approve

@xing-yang
Copy link
Contributor

/assign @dims

@dims
Copy link
Member

dims commented Aug 1, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, wongma7, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants