Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump cAdvisor to v0.46.0 #113769

Merged
merged 1 commit into from Nov 9, 2022
Merged

deps: Bump cAdvisor to v0.46.0 #113769

merged 1 commit into from Nov 9, 2022

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Nov 9, 2022 •
edited

Signed-off-by: David Porter david@porter.me

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump cAdvisor to the latest version. See google/cadvisor@v0.45.0...v0.46.0 for diff.

No significant changes, mostly dependency updates.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updated cAdvisor to v0.46.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@bobbypage
deps: Bump cAdvisor to v0.46.0
a2c4672 
Signed-off-by: David Porter <david@porter.me>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

@bobbypage: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2022
@bobbypage
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 9, 2022
@bobbypage
Copy link
Member Author

/assign @dims @liggitt

@liggitt
Copy link
Member

liggitt commented Nov 9, 2022 

{
 	"directDependencies": 212,
-	"transitiveDependencies": 235,
-	"totalDependencies": 286,
+	"transitiveDependencies": 234,
+	"totalDependencies": 285,
 	"maxDepthOfDependencies": 26
 }

@liggitt
Copy link
Member

liggitt commented Nov 9, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2022
@dims
Copy link
Member

dims commented Nov 9, 2022

/approve
/lgtm

( for posterity! :) )

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Nov 9, 2022

/skip
/retest

@bobbypage
Copy link
Member Author

/retest

@liggitt
Copy link
Member

liggitt commented Nov 9, 2022

this lacks the milestone, I know we typically bump to a cadvisor tag just prior to release, so I'll defer to node owners and release folks on adding it to the milestone

@dims
Copy link
Member

dims commented Nov 9, 2022

wearing my sig-node reviewer hat and this was on the borderline

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 9, 2022
@klueska
Copy link
Contributor

klueska commented Nov 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 37e73b4 into kubernetes:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dims dims

@klueska klueska

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bobbypage @k8s-ci-robot @liggitt @dims @pacoxu @klueska