@divyenpatel: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

/milestone 1.22

@divyenpatel: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

/milestone 1.22

@xing-yang: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

/milestone v1.22

/sig storage
/sig cloud-provider

/assign @msau42
/assign @Jiawei0227

/retest

/assign @gnufied

/retest

Couple of questions:

1. Did we solve the NFS datastore issues in CSI driver? I did not hear a resolution or a deprecation notice for nfs datastore.
2. In last release we deprecated bunch of previously supported stuff - deprecating in-tree vsphere volume diskformat parameters, vsphere less than 67u3, vm hardware less than 15 and multi vCenter support #98546 and our deprecation notice contains following message - "Support for these deprecations will be available till Kubernetes v1.24.". But enabling migration by default in 1.22 basically will make those parameters unsupported in 1.22 itself unless users explicitly disable the feature gate. Was this discussed as agreed path? I personally think - this will catch many users off-guard.

Did we solve the NFS datastore issues in CSI driver? I did not hear a resolution or a deprecation notice for nfs datastore.

First Class Disk used by vSphere CSI Driver does not support NFSv4 datastore. Refer to known VSLM issues here.

In last release we deprecated bunch of previously supported stuff and our deprecation notice contains following message - "Support for these deprecations will be available till Kubernetes v1.24.". But enabling migration by default in 1.22 basically will make those parameters unsupported in 1.22 itself unless users explicitly disable the feature gate.

We will continue to support deprecated parameters until 1.24. Users still have an option to disable migration on their cluster while upgrading to 1.22.

Was this discussed as agreed path? I personally think - this will catch many users off-guard.

Yes this was discussed in the sig architecture meeting. Refer to #98546 (comment) and meeting notes. - Section: "Agenda notes for February 11, 2021".

First Class Disk used by vSphere CSI Driver does not support NFSv4 datastore. Refer to known VSLM issues here.

Thanks for the link. In which case - we may have to deprecate NFSv4 datastore support completely with the intree driver. Also - are NFSv3 datastores supported by CSI driver? Can customers use that as a fallback? It should be noted that - if you add a NFS datastore in vcenter, vcenter recommends NFSv3 only for ESXI hosts older than 6.0. So I suspect - many folks will try and use NFSv4 with vsphere and fail.

/milestone v1.24

@divyenpatel: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

/milestone v1.24

We discussed this today in CSI implementation meeting and since we only deprecated vSphere versions < 6.7u3 previously ( #98546 ) and since migration requires 7.0.1 at minimum - we will have to deprecate all versions of vSphere prior to 7.0.1 if we want to enable migration by default. Please consider this requirement before we can enable the migration.

✋ I am from the v1.24 bug triage team , code freeze is on 03/30 so just wanted to remind to get this PR merged before that to target v1.24 :)

@DiptoChakrabarty We are delaying this PR to a later release.

/milestone clear

/milestone v1.25

Have we addressed concern that @gnufied has?

I believe kubernetes-sigs/vsphere-csi-driver#1653 issue should be a blocker before we can enable CSI migration as default for vsphere.

I believe kubernetes-sigs/vsphere-csi-driver#1653 issue should be a blocker before we can enable CSI migration as default for vsphere.

@gnufied I have fixed this issue in the vSphere CSI Driver.
kubernetes-sigs/vsphere-csi-driver#1854

Note: After this change in the vSphere CSI Driver, In-tree static vSphere PV will get migrated and registered as FCD when vSphere CSI Driver is installed with csi-migration feature-gate enabled, even when migration is not enabled on the kube-controller or kubelet.

cc: @jsafrane

/milestone v1.25

@Jiawei0227

@gnufied 's concern is addressed in the vSphere CSI Driver.

@Jiawei0227
@gnufied 's concern is addressed in the vSphere CSI Driver.

Merging this PR.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

We should also document that - k8s 1.25 drops (we previously deprecated) support for older versions. We previously agreed that:

1. 1.24 is last version will support < 6.7u3, since CSI migration does not work properly on that version. So we should mention that k8s 1.25 will completely drop support for vsphere 6.7u3. Anyone installing or upgrading to 1.25 should not be on 6.7 or older versions.
2. Support for versions older than 7.0u2 is something we agreed was iffy. In last release we deprecated support for <7.0u2. Since migration only works with caveats in those versions, we should remove support for anything <7.0u2 in k8s 1.25.
3. I am not sure about Windows support, since it is still alpha but since at basic level it works, I think we need to call out.

cc @msau42 @jsafrane

We probably need to communicate this to wider community

We should also document that - k8s 1.25 drops (we previously deprecated) support for older versions. We previously agreed that:

1.24 is last version will support < 6.7u3, since CSI migration does not work properly on that version. So we should mention that k8s 1.25 will completely drop support for vsphere 6.7u3. Anyone installing or upgrading to 1.25 should not be on 6.7 or older versions.
Support for versions older than 7.0u2 is something we agreed was iffy. In last release we deprecated support for <7.0u2. Since migration only works with caveats in those versions, we should remove support for anything <7.0u2 in k8s 1.25.
I am not sure about Windows support, since it is still alpha but since at basic level it works, I think we need to call out.
cc @msau42 @jsafrane

We probably need to communicate this to wider community

Addressed by this PR: #111255
cc @gnufied @msau42 @jsafrane @Jiawei0227 @jingxu97