New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling CSIMigrationvSphere feature by default #103523
enabling CSIMigrationvSphere feature by default #103523
Conversation
@divyenpatel: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 1.22 |
@divyenpatel: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 1.22 |
@xing-yang: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v1.22 |
/sig storage |
/assign @msau42 |
/retest |
/assign @gnufied |
/retest |
Couple of questions:
|
First Class Disk used by vSphere CSI Driver does not support NFSv4 datastore. Refer to known VSLM issues here.
We will continue to support deprecated parameters until 1.24. Users still have an option to disable migration on their cluster while upgrading to 1.22.
Yes this was discussed in the sig architecture meeting. Refer to #98546 (comment) and meeting notes. - Section: "Agenda notes for February 11, 2021". |
Thanks for the link. In which case - we may have to deprecate NFSv4 datastore support completely with the intree driver. Also - are NFSv3 datastores supported by CSI driver? Can customers use that as a fallback? It should be noted that - if you add a NFS datastore in vcenter, vcenter recommends NFSv3 only for ESXI hosts older than 6.0. So I suspect - many folks will try and use NFSv4 with vsphere and fail. |
/milestone v1.24 |
@divyenpatel: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v1.24 |
We discussed this today in CSI implementation meeting and since we only deprecated vSphere versions < 6.7u3 previously ( #98546 ) and since migration requires 7.0.1 at minimum - we will have to deprecate all versions of vSphere prior to 7.0.1 if we want to enable migration by default. Please consider this requirement before we can enable the migration. |
✋ I am from the v1.24 bug triage team , code freeze is on 03/30 so just wanted to remind to get this PR merged before that to target v1.24 :) |
@DiptoChakrabarty We are delaying this PR to a later release. |
/milestone clear |
/milestone v1.25 |
9a601df
to
dfba13a
Compare
Have we addressed concern that @gnufied has? |
I believe kubernetes-sigs/vsphere-csi-driver#1653 issue should be a blocker before we can enable CSI migration as default for vsphere. |
@gnufied I have fixed this issue in the vSphere CSI Driver. Note: After this change in the vSphere CSI Driver, In-tree static vSphere PV will get migrated and registered as FCD when vSphere CSI Driver is installed with csi-migration feature-gate enabled, even when migration is not enabled on the kube-controller or kubelet. cc: @jsafrane |
/milestone v1.25 |
@gnufied 's concern is addressed in the vSphere CSI Driver. |
Merging this PR. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We should also document that - k8s 1.25 drops (we previously deprecated) support for older versions. We previously agreed that:
We probably need to communicate this to wider community |
Addressed by this PR: #111255 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is enabling CSIMigrationvSphere feature by default for the upcoming Kubernetes Release 1.25.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Test Logs
https://gist.github.com/divyenpatel/f8e7afe6c67068b008de2f6bbd8c82f9
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: