New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kube-apiserver: mark unused master-service-namespace flag as deprecated #112797
kube-apiserver: mark unused master-service-namespace flag as deprecated #112797
Conversation
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/triage accepted |
What type of PR is this?
/kind deprecation
What this PR does / why we need it:
The
master-service-namespace
flag was already deprecated by #38186 since v1.6, and it takes nothing effect now.But we have never given an exact removal date.
This PR marks it deprecated and hides it from the flag list, expects it to be completely removed in v1.27.
FYI: Deprecating a flag or CLI
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: