Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove podOverhead feature gate as a feature is now GA since 1.24 #112579

Merged
merged 1 commit into from Sep 22, 2022
Merged

remove podOverhead feature gate as a feature is now GA since 1.24 #112579

merged 1 commit into from Sep 22, 2022

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind cleanup
/sig node

What this PR does / why we need it:

Just a cleanup of old feature gate

KEP: kubernetes/enhancements#688

PodOverhead feature gate was removed as the feature is in GA since 1.24

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2022
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Sep 19, 2022
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 19, 2022
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Sep 19, 2022
Closed
sanposhiho
sanposhiho reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from sig/scheduling
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Needs Approver in SIG Node PR Triage Sep 20, 2022
@pacoxu
Copy link
Member

pacoxu commented Sep 21, 2022

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2022
@dims
Copy link
Member

dims commented Sep 21, 2022

/approve
/lgtm
/assign @liggitt
(for API approval)

@liggitt
Copy link
Member

liggitt commented Sep 22, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, pacoxu, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5ce4f98 into kubernetes:master Sep 22, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Sep 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 22, 2022
@pacoxu pacoxu mentioned this pull request Nov 8, 2022
Closed
@SergeyKanzhelev SergeyKanzhelev deleted the removePodOverhead branch January 23, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@pacoxu pacoxu pacoxu approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@dims dims

@liggitt liggitt

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SergeyKanzhelev @pacoxu @dims @liggitt @k8s-ci-robot @sanposhiho