New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate SeccompDefault feature to beta #110805
Graduate SeccompDefault feature to beta #110805
Conversation
/test pull-kubernetes-node-kubelet-serial-containerd |
/test pull-kubernetes-node-kubelet-serial-containerd |
5d1e1a2
to
2d43c6b
Compare
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1 |
/test pull-kubernetes-node-kubelet-serial-containerd |
As outlined in the KEP, we now graduate the Kubelet feature to beta which means that it is enabled by default. The corresponding Kubelet flag still defaults to `false`, but we now have the chance to e2e test the feature by using a new serial test case. KEP: kubernetes/enhancements#2413 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2d43c6b
to
a4f966a
Compare
/test pull-kubernetes-node-kubelet-serial-containerd |
Serial tests succeeded, this is ready for review. PTAL @kubernetes/sig-node-pr-reviews |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
for test/e2e_node changes
/approve for pkg/features/ |
@saschagrunert: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, endocrimes, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
For the extended changelog, could we link to https://kubernetes.io/docs/tutorials/security/seccomp/#enable-the-use-of-runtimedefault-as-the-default-seccomp-profile-for-all-workloads ? |
Done, do the current notes fit your expectations? |
@saschagrunert I'd have put
in the other section for notes (the section headed Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As outlined in the KEP, we now graduate the Kubelet feature to beta which means that it is enabled by default. The corresponding Kubelet flag still defaults to
false
, but we now have the chance to e2e test the feature by using a new serial test case.Which issue(s) this PR fixes:
Refers to: kubernetes/enhancements#2413
Docs PR: kubernetes/website#34640
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: