Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate SeccompDefault feature to beta #110805

Merged
merged 1 commit into from Jul 8, 2022
Merged

Graduate SeccompDefault feature to beta #110805

merged 1 commit into from Jul 8, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 27, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

As outlined in the KEP, we now graduate the Kubelet feature to beta which means that it is enabled by default. The corresponding Kubelet flag still defaults to false, but we now have the chance to e2e test the feature by using a new serial test case.

Which issue(s) this PR fixes:

Refers to: kubernetes/enhancements#2413
Docs PR: kubernetes/website#34640

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Graduated SeccompDefault to `beta`. The Kubelet feature gate is now enabled by default and the configuration/CLI flag still defaults to `false`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- KEP: https://github.com/kubernetes/enhancements/issues/2413
- Docs: https://kubernetes.io/docs/tutorials/security/seccomp/#enable-the-use-of-runtimedefault-as-the-default-seccomp-profile-for-all-workloads

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 27, 2022
@saschagrunert saschagrunert mentioned this pull request Jun 27, 2022
Closed
12 tasks
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial-containerd

@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 27, 2022
@saschagrunert saschagrunert mentioned this pull request Jun 27, 2022
Merged
@saschagrunert saschagrunert added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 27, 2022
@saschagrunert saschagrunert added this to the v1.25 milestone Jun 27, 2022
@saschagrunert saschagrunert self-assigned this Jun 27, 2022
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial-containerd

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1

@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial-containerd

@saschagrunert
Graduate SeccompDefault feature to beta
a4f966a 
As outlined in the KEP, we now graduate the Kubelet feature to beta
which means that it is enabled by default. The corresponding Kubelet
flag still defaults to `false`, but we now have the chance to e2e test
the feature by using a new serial test case.

KEP: kubernetes/enhancements#2413

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial-containerd
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1

@saschagrunert
Copy link
Member Author

Serial tests succeeded, this is ready for review. PTAL @kubernetes/sig-node-pr-reviews

@pacoxu pacoxu added this to Triage in SIG Node PR Triage Jun 28, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 28, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 28, 2022
@pacoxu pacoxu moved this from Triage to Needs Reviewer in SIG Node PR Triage Jun 28, 2022
endocrimes
endocrimes approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

for test/e2e_node changes

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@endocrimes endocrimes moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jul 7, 2022
@dims
Copy link
Member

dims commented Jul 7, 2022

/approve
/lgtm

for pkg/features/

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-ipv6 a4f966a link unknown /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-gce-ubuntu-containerd a4f966a link unknown /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, endocrimes, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2b657a0 into kubernetes:master Jul 8, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jul 8, 2022
@saschagrunert saschagrunert deleted the seccomp-default-beta branch July 8, 2022 06:58
@sftim
Copy link
Contributor

sftim commented Jul 13, 2022

For the extended changelog, could we link to https://kubernetes.io/docs/tutorials/security/seccomp/#enable-the-use-of-runtimedefault-as-the-default-seccomp-profile-for-all-workloads ?

@saschagrunert
Copy link
Member Author

For the extended changelog, could we link to https://kubernetes.io/docs/tutorials/security/seccomp/#enable-the-use-of-runtimedefault-as-the-default-seccomp-profile-for-all-workloads ?

Done, do the current notes fit your expectations?

@sftim
Copy link
Contributor

sftim commented Jul 13, 2022

@saschagrunert I'd have put

For more information how to use the feature, refer to: https://kubernetes.io/docs/tutorials/security/seccomp/#enable-the-use-of-runtimedefault-as-the-default-seccomp-profile-for-all-workloads

in the other section for notes (the section headed Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:)

@ialidzhikov ialidzhikov mentioned this pull request Jul 26, 2022
Merged
@ialidzhikov ialidzhikov mentioned this pull request Oct 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@endocrimes endocrimes endocrimes approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

@saschagrunert saschagrunert

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@saschagrunert @pacoxu @dims @k8s-ci-robot @k8s-triage-robot @sftim @mrunalp @endocrimes