New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using the deprecated Measure
method
#111065
Conversation
As what suggested by Ginkgo migration guide, `Measure` node was deprecated and replaced with `It` node which creates `gmeasure.Experiment`. Signed-off-by: Dave Chen <dave.chen@arm.com>
@chendave: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chendave: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @aojea :) |
/approve for deps deferring lgtm to @onsi ack |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this looks good to me. not sure if there are any consumers downstream scraping the test output to record the result of the measurement... if so, those might need to change. |
people should not rely on the test output 😈 , that contract doesn't exist AFAIK /lgtm Thanks onsi for taking the time on this |
/release-note-none |
@oomichi: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
release-note-edit |
As what suggested by Ginkgo migration guide,
Measure
node wasdeprecated and replaced with
It
node which createsgmeasure.Experiment
.Signed-off-by: Dave Chen dave.chen@arm.com
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #109744
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig testing