New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 'running_managed_controllers' for KCM nodeipam controller #111466
Conversation
/assign @cheftako |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this generally makes sense to me
/lgtm
FTR: I do not want to change |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, jprzychodzen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @ogicalhan Do we need to do anything like mark these metrics as alpha/beta? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables
running_managed_controllers
for nodeipam controller running inside KCM.This metric support HA migration described in KEP-2436
Which issue(s) this PR fixes:
It doesn't fix, but is a part of #111029
Special notes for your reviewer:
First PR is already merged. See #111033.
Second PR is in-flight. See #111462
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cloud-provider