New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix match onExitCodes when Pod is not terminated #113856
Conversation
Change-Id: Id1f9c46f8b6a12115577a1fadb12adc580c9ba6a
@alculquicondor: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @soltysh |
/priority critical-urgent |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alculquicondor can you backport to 1.25? |
I'm not sure. This is a crash, but only when the alpha feature is enabled. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks Does this qualify for backport @kubernetes/sig-release-leads? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix a panic in job controller when the Job has
podFailurePolicy
and a Pod is still terminating.Which issue(s) this PR fixes:
Fixes #113852
Special notes for your reviewer:
Since there was no release yet, the release note focuses on the limitation described in #113855
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: