Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix match onExitCodes when Pod is not terminated #113856

Merged
merged 1 commit into from Nov 11, 2022
Merged

Fix match onExitCodes when Pod is not terminated #113856

merged 1 commit into from Nov 11, 2022

Conversation

alculquicondor
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix a panic in job controller when the Job has podFailurePolicy and a Pod is still terminating.

Which issue(s) this PR fixes:

Fixes #113852

Special notes for your reviewer:

Since there was no release yet, the release note focuses on the limitation described in #113855

Does this PR introduce a user-facing change?

Known issue: Job field `.spec.podFailurePolicy.rules[*].onExitCode` might be ignored if the Pod is deleted before it terminates.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/e3f3faeb899e5739db4bbbd60a56715f6a4e8b45/keps/sig-apps/3329-retriable-and-non-retriable-failures

@alculquicondor
Fix match onExitCodes when Pod is not terminated
bc5afaf 
Change-Id: Id1f9c46f8b6a12115577a1fadb12adc580c9ba6a
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 11, 2022
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 11, 2022
@alculquicondor
Copy link
Member Author

/assign @soltysh

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2022
@alculquicondor alculquicondor mentioned this pull request Nov 11, 2022
Closed
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2022
@alculquicondor
Copy link
Member Author

/unassign @soltysh
(holiday)

/assign @liggitt

@k8s-ci-robot k8s-ci-robot assigned liggitt and unassigned soltysh Nov 11, 2022
@alculquicondor
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2022
@liggitt
Copy link
Member

liggitt commented Nov 11, 2022

/lgtm
/approve
/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af7cc0a into kubernetes:master Nov 11, 2022
@ialidzhikov
Copy link
Contributor

@alculquicondor can you backport to 1.25?

@alculquicondor
Copy link
Member Author

I'm not sure. This is a crash, but only when the alpha feature is enabled. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks

Does this qualify for backport @kubernetes/sig-release-leads?

@alculquicondor alculquicondor mentioned this pull request Nov 15, 2022
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortent mortent Awaiting requested review from mortent

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Panic on job controller
5 participants
@alculquicondor @k8s-ci-robot @liggitt @ialidzhikov @soltysh