Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'metrics/slis' to kcm health checks #112978

Merged
merged 1 commit into from Oct 12, 2022
Merged

add 'metrics/slis' to kcm health checks #112978

merged 1 commit into from Oct 12, 2022

Conversation

logicalhan
Copy link
Member

@logicalhan logicalhan commented Oct 11, 2022 •
edited

Change-Id: I8c2114e538bb417deff8c3f9f107758c089227dc

What type of PR is this?

/kind feature

Fixes #112958

What this PR does / why we need it:

Adds health check SLI metrics to KCM. This is behind a feature gate.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

If `ComponentSLIs` feature gate is enabled, then `/metrics/slis` becomes available on kube-controller-manager, allowing you to scrape health check metrics.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/3466

# HELP kubernetes_healthcheck [ALPHA] This metric records the result of a single healthcheck.
# TYPE kubernetes_healthcheck gauge
kubernetes_healthcheck{name="attachdetach",type="healthz"} 1
kubernetes_healthcheck{name="clusterrole-aggregation",type="healthz"} 1
kubernetes_healthcheck{name="cronjob",type="healthz"} 1
kubernetes_healthcheck{name="csrapproving",type="healthz"} 1
kubernetes_healthcheck{name="csrcleaner",type="healthz"} 1
kubernetes_healthcheck{name="csrsigning",type="healthz"} 1
kubernetes_healthcheck{name="daemonset",type="healthz"} 1
kubernetes_healthcheck{name="deployment",type="healthz"} 1
kubernetes_healthcheck{name="disruption",type="healthz"} 1
kubernetes_healthcheck{name="endpoint",type="healthz"} 1
kubernetes_healthcheck{name="endpointslice",type="healthz"} 1
kubernetes_healthcheck{name="endpointslicemirroring",type="healthz"} 1
kubernetes_healthcheck{name="ephemeral-volume",type="healthz"} 1
kubernetes_healthcheck{name="garbagecollector",type="healthz"} 1
kubernetes_healthcheck{name="horizontalpodautoscaling",type="healthz"} 1
kubernetes_healthcheck{name="job",type="healthz"} 1
kubernetes_healthcheck{name="namespace",type="healthz"} 1
kubernetes_healthcheck{name="nodelifecycle",type="healthz"} 1
kubernetes_healthcheck{name="persistentvolume-binder",type="healthz"} 1
kubernetes_healthcheck{name="persistentvolume-expander",type="healthz"} 1
kubernetes_healthcheck{name="podgc",type="healthz"} 1
kubernetes_healthcheck{name="pv-protection",type="healthz"} 1
kubernetes_healthcheck{name="pvc-protection",type="healthz"} 1
kubernetes_healthcheck{name="replicaset",type="healthz"} 1
kubernetes_healthcheck{name="replicationcontroller",type="healthz"} 1
kubernetes_healthcheck{name="resourcequota",type="healthz"} 1
kubernetes_healthcheck{name="root-ca-cert-publisher",type="healthz"} 1
kubernetes_healthcheck{name="serviceaccount",type="healthz"} 1
kubernetes_healthcheck{name="statefulset",type="healthz"} 1
kubernetes_healthcheck{name="ttl",type="healthz"} 1
kubernetes_healthcheck{name="ttl-after-finished",type="healthz"} 1
# HELP kubernetes_healthchecks_total [ALPHA] This metric records the results of all healthcheck.
# TYPE kubernetes_healthchecks_total counter
kubernetes_healthchecks_total{name="attachdetach",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="clusterrole-aggregation",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="cronjob",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="csrapproving",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="csrcleaner",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="csrsigning",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="daemonset",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="deployment",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="disruption",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="endpoint",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="endpointslice",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="endpointslicemirroring",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="ephemeral-volume",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="garbagecollector",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="horizontalpodautoscaling",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="job",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="namespace",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="nodelifecycle",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="persistentvolume-binder",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="persistentvolume-expander",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="podgc",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="pv-protection",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="pvc-protection",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="replicaset",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="replicationcontroller",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="resourcequota",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="root-ca-cert-publisher",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="serviceaccount",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="statefulset",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="ttl",status="success",type="healthz"} 2
kubernetes_healthchecks_total{name="ttl-after-finished",status="success",type="healthz"} 2

@logicalhan
add 'metrics/slis' to kcm health checks
bd2417b 
Change-Id: I8c2114e538bb417deff8c3f9f107758c089227dc
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 11, 2022
logicalhan
logicalhan commented Oct 11, 2022
View reviewed changes
Copy link
Member Author

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sig cloud-provider
/assign @cheftako

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2022
@richabanker
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@richabanker: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 11, 2022
@cheftako
Copy link
Member

Do we have a way to point users at the meaning for values 1 or 2?

@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, logicalhan, Richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 335fd41 into kubernetes:master Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 12, 2022
@logicalhan logicalhan mentioned this pull request Oct 13, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@humblec humblec Awaiting requested review from humblec

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@cheftako cheftako

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Wire up metrics/slis for kube-controller-manager
5 participants
@logicalhan @richabanker @k8s-ci-robot @fedebongio @cheftako