New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubeadm cleanup for taint / toleration with master label #112008
Conversation
/test pull-kubernetes-conformance-kind-ga-only-parallel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on a quick look, i will get back to this to double check and write release note.
in 1.25 we had a number of other PRs:
kubernetes/kubeadm#2200
for k/website, k-sigs/kind, KEP etc.
EDIT: i will help sending these.
@pacoxu |
/release-note-edit
|
/triage accepted |
cc @fabriziopandini @sbueringer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't see any other required changes so LGTM, thanks @pacoxu
/lgtm
/approve
/hold
let's hold until next week and we can remove the hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#2200
Special notes for your reviewer:
Does this PR introduce a user-facing change?