Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove out-of-support Windows 20H2 images #112924

Merged
merged 1 commit into from Oct 13, 2022
Merged

cleanup: Remove out-of-support Windows 20H2 images #112924

merged 1 commit into from Oct 13, 2022

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Oct 7, 2022

Signed-off-by: Mark Rossetti marosset@microsoft.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Windows Server, Version 20H2 is out of support so we shouldn't be building container images for that version anymore.

Note: This is the last SAC (18 month support) of Windows Server we supported in K8s. From now on only LTSC (5 year support) versions of Windows server will be supported here.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removing Windows Server, Version 20H2 flavors from various container images

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2022
@marosset
Copy link
Contributor Author

marosset commented Oct 7, 2022

/milestone v1.26
/assign @claudiubelu @jsturtevant
For SIG-Windows review

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 7, 2022
@dims
Copy link
Member

dims commented Oct 8, 2022 

INFO Validating zeitgeist options...              
ERRO /home/prow/go/src/k8s.io/kubernetes/build/dependencies.yaml indicates that registry.k8s.io/pause should be at version 3.8, but the following files didn't match: build/pause/Makefile 
FATA Dependencies are not in sync

@marosset
Copy link
Contributor Author 

INFO Validating zeitgeist options...              
ERRO /home/prow/go/src/k8s.io/kubernetes/build/dependencies.yaml indicates that registry.k8s.io/pause should be at version 3.8, but the following files didn't match: build/pause/Makefile 
FATA Dependencies are not in sync

Let me update this

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 11, 2022
@claudiubelu
Copy link
Contributor

LGTM for the test image changes. With this, there are no 20H2 references in this project.

@marosset
Copy link
Contributor Author 

INFO Validating zeitgeist options...              
ERRO /home/prow/go/src/k8s.io/kubernetes/build/dependencies.yaml indicates that registry.k8s.io/pause should be at version 3.8, but the following files didn't match: build/pause/Makefile 
FATA Dependencies are not in sync

Let me update this

Updated

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 12, 2022
@marosset marosset mentioned this pull request Oct 12, 2022
Merged
@marosset
Copy link
Contributor Author

/assign @jpbetz
For etcd image updates

@jpbetz
Copy link
Contributor

jpbetz commented Oct 12, 2022

/approve
for etcd changes

@jsturtevant
Copy link
Contributor

changes look good to me, Do we need to update the change log here https://github.com/kubernetes/kubernetes/blob/master/build/pause/CHANGELOG.md?

@dims
Copy link
Member

dims commented Oct 12, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpbetz, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@marosset
Copy link
Contributor Author

changes look good to me, Do we need to update the change log here https://github.com/kubernetes/kubernetes/blob/master/build/pause/CHANGELOG.md?

I can do that.
Since that md references the PRs there is a chicken-and-egg problem :-/

@marosset
Remove out-of-support Windows 20H2 images
ecd543b 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset
Copy link
Contributor Author

changes look good to me, Do we need to update the change log here https://github.com/kubernetes/kubernetes/blob/master/build/pause/CHANGELOG.md?

I can do that. Since that md references the PRs there is a chicken-and-egg problem :-/

Added

@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 13, 2022
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@marosset
Copy link
Contributor Author

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit b601769 into kubernetes:master Oct 13, 2022
@claudiubelu claudiubelu mentioned this pull request Oct 24, 2022
Merged
claudiubelu added a commit to claudiubelu/k8s.io that referenced this pull request Nov 2, 2022
@claudiubelu
Promotes E2E images
5b61ac5 
Promotes E2E images which were updated in the [0] PR, which removed the Windows Server 20H2 support in the E2E images.

These hashes has been obtained by running:

```
#!/bin/bash

declare -a images=(agnhost:2.41 busybox:1.29-4 httpd:2.4.39-4 httpd:2.4.38-4 jessie-dnsutils:1.7 kitten:1.7 nautilus:1.7 nginx:1.15-4 nginx:1.14-4 nonroot:1.4 redis:5.0.5-3 resource-consumer:1.12 sample-apiserver:1.17.7)

for image in "${images[@]}"; do
  echo "Image: ${image} - $(manifest-tool inspect --raw gcr.io/k8s-staging-e2e-test-images/${image} | jq '.digest')"
done

```

[1] kubernetes/kubernetes#112924
@claudiubelu claudiubelu mentioned this pull request Nov 2, 2022
Merged
claudiubelu added a commit to claudiubelu/k8s.io that referenced this pull request Nov 2, 2022
@claudiubelu
Promotes E2E images
d08e1b8 
Promotes E2E images which were updated in the [0] PR, which removed the Windows Server 20H2 support in the E2E images.

These hashes has been obtained by running:

```

declare -a images=(agnhost:2.41 busybox:1.29-4 httpd:2.4.39-4 httpd:2.4.38-4 jessie-dnsutils:1.7 kitten:1.7 nautilus:1.7 nginx:1.15-4 nginx:1.14-4 nonroot:1.4 redis:5.0.5-3 resource-consumer:1.12 sample-apiserver:1.17.7)

for image in "${images[@]}"; do
  echo "Image: ${image} - $(manifest-tool inspect --raw gcr.io/k8s-staging-e2e-test-images/${image} | jq '.digest')"
done

```

[1] kubernetes/kubernetes#112924
claudiubelu added a commit to claudiubelu/k8s.io that referenced this pull request Nov 3, 2022
@claudiubelu
Promotes E2E images
c922f5b 
Promotes E2E images which were updated in the [0] PR, which removed the Windows Server 20H2 support in the E2E images.

These hashes has been obtained by running:

```

declare -a images=(agnhost:2.41 busybox:1.29-4 httpd:2.4.39-4 httpd:2.4.38-4 jessie-dnsutils:1.7 kitten:1.7 nautilus:1.7 nginx:1.15-4 nginx:1.14-4 nonroot:1.4 redis:5.0.5-3 resource-consumer:1.12 sample-apiserver:1.17.7)

for image in "${images[@]}"; do
  echo "Image: ${image} - $(manifest-tool inspect --raw gcr.io/k8s-staging-e2e-test-images/${image} | jq '.digest')"
done

```

[1] kubernetes/kubernetes#112924
This was referenced Nov 14, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@serathius serathius Awaiting requested review from serathius

Assignees

@jpbetz jpbetz

@jsturtevant jsturtevant

@claudiubelu claudiubelu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marosset @dims @fedebongio @claudiubelu @jpbetz @jsturtevant @k8s-ci-robot @leilajal