New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix params to be null instead of an empty map if paramRef is null #113749
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
98aa9b0
to
d54d22e
Compare
d54d22e
to
65460b1
Compare
/lgtm |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a bug in validation admission policies (alpha in 1.26) where if a ValidatingAdmissionPolicy has a paramKind but the ValidatingAdmissionPolicyBinding has no paramRef, then in CEL expressions,
param
is an empty map, but should benull
. This results inparam == null
evaluating to false.Which issue(s) this PR fixes:
Found by @andrewsykim while expanding integration test coverage for validating admission policies.
Special notes for your reviewer:
Validated locally that the included unit test fails without the code fix.
Does this PR introduce a user-facing change?
/cc @cici37 @andrewsykim
/sig api-machinery