Fix params to be null instead of an empty map if paramRef is null #113749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
jpbetz
force-pushed
the
fix-params-null
branch
from
98aa9b0
to
d54d22e
Compare
jpbetz
force-pushed
the
fix-params-null
branch
from
d54d22e
to
65460b1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a bug in validation admission policies (alpha in 1.26) where if a ValidatingAdmissionPolicy has a paramKind but the ValidatingAdmissionPolicyBinding has no paramRef, then in CEL expressions,
paramis an empty map, but should benull. This results inparam == nullevaluating to false.Which issue(s) this PR fixes:
Found by @andrewsykim while expanding integration test coverage for validating admission policies.
Special notes for your reviewer:
Validated locally that the included unit test fails without the code fix.
Does this PR introduce a user-facing change?
/cc @cici37 @andrewsykim
/sig api-machinery